You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/04/28 11:51:06 UTC
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/171
CB-11139 Use PluginManager from common to install/uninstall plugins
This PR removes a lot of the code, related to plugin installation in favor of unified `PluginManager` class, available since `cordova-common@1.2.0` (see [CB-10833](https://issues.apache.org/jira/browse/CB-10833) and apache/cordova-lib#414)
JIRA: [CB-11139](https://issues.apache.org/jira/browse/CB-11139)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-11139
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit 65a084a623592967a68aa9e7c7cf2d62fd362118
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2016-04-22T12:38:15Z
CB-11139 Use PluginManager from common to install/uninstall plugins
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215523674
@jasongin Can you please help review? Related to apache/cordova-android#301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215373720
## [Current coverage][cc-pull] is **100%**
> Merging [#171][cc-pull] into [master][cc-base-branch] will not change coverage
```diff
@@ master #171 diff @@
==========================================
Files 14 14
Lines 3202 3213 +11
Methods 339 341 +2
Messages 0 0
Branches 451 451
==========================================
+ Hits 3202 3213 +11
Misses 0 0
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by eed7ebe
[cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/171?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215891369
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org