You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/06/01 12:51:41 UTC
Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1428
https://issues.apache.org/jira/browse/LENS-1428
Repository: lens
Description
-------
For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
Diff: https://reviews.apache.org/r/59714/diff/1/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176900
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java
Lines 359 (patched)
<https://reviews.apache.org/r/59714/#comment250441>
Should we rename the method to decideMeasurePhraseToAnswer and parameter to measurePhraseIndices ?
Also please add method level comments
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
Lines 833 (patched)
<https://reviews.apache.org/r/59714/#comment250442>
Can we leave a comment in code why this is needed.
- Puneet Gupta
On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 12:51 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
>
>
> Repository: lens
>
>
> Description
> -------
>
> For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
>
>
> Diff: https://reviews.apache.org/r/59714/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176907
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On June 5, 2017, 8:51 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 8:51 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
>
>
> Repository: lens
>
>
> Description
> -------
>
> For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
>
>
> Diff: https://reviews.apache.org/r/59714/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/
-----------------------------------------------------------
(Updated June 5, 2017, 8:51 a.m.)
Review request for lens.
Changes
-------
Addressed review.
Bugs: LENS-1428
https://issues.apache.org/jira/browse/LENS-1428
Repository: lens
Description
-------
For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
Diff: https://reviews.apache.org/r/59714/diff/2/
Changes: https://reviews.apache.org/r/59714/diff/1-2/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
Posted by Sushil Mohanty <su...@gmail.com>.
> On June 2, 2017, 4:01 a.m., Amareshwari Sriramadasu wrote:
> > Please include unit tests
Added as part of https://reviews.apache.org/r/59744/. I have schema setup here to reproduce this.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176728
-----------------------------------------------------------
On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 12:51 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
>
>
> Repository: lens
>
>
> Description
> -------
>
> For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
>
>
> Diff: https://reviews.apache.org/r/59714/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 59714: LENS-1428 : Common measures are getting
repeated in UnionQuery for JoinCandidate
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176728
-----------------------------------------------------------
Please include unit tests
- Amareshwari Sriramadasu
On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 12:51 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
>
>
> Repository: lens
>
>
> Description
> -------
>
> For JoinCandidate if a measure is answerable by its children, getting projected in both. Instead the measure should be projected in one of the children and default measure i.e 0.0 for the other.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
>
>
> Diff: https://reviews.apache.org/r/59714/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>