[GitHub] [kafka] vladimirdyuzhev commented on a diff in pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

[GitBox <gi...@apache.org>]

vladimirdyuzhev commented on code in PR #13081:
URL: https://github.com/apache/kafka/pull/13081#discussion_r1063475320


##########
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java:
##########
@@ -90,6 +91,7 @@ public void configure(Map<String, ?> configs, String contextName, Configuration
         this.minTimeBeforeRelogin = (Long) configs.get(SaslConfigs.SASL_KERBEROS_MIN_TIME_BEFORE_RELOGIN);
         this.kinitCmd = (String) configs.get(SaslConfigs.SASL_KERBEROS_KINIT_CMD);
         this.serviceName = getServiceName(configs, contextName, configuration);
+        this.callbackHandler = callbackHandler;

Review Comment:
   We can extract `loginCallbackHandler()` into AbstractLogin, true. I was trying to limit the change to the Kerberos code because I don't have a way to verify the impact across all other login methods.
   
   I will create JIRA, no problem. 
   
   I'm not immediately sure how to create a test for it within the Kafka code base - I don't see the live Kerberos tests in the tests/ tree. Will look into that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org