You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/15 10:32:04 UTC
[GitHub] [rocketmq] jjz921024 opened a new pull request #2302: [ISSUE apache#2152] add isRunning method in DefaultLitePullConsumerIm…
jjz921024 opened a new pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302
…pl class and test suit
## What is the purpose of the change
fix about issue#2152, and add isRuning method for indacate consumer is still running
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] jjz921024 commented on pull request #2302: [ISSUE #2152] Add isRunning method in DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
jjz921024 commented on pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302#issuecomment-694214621
> > @RongtongJin @jjz921024 The test seems to be time-consuming. Unit test could use mock style.
>
> Copy that, and i also note that, i will fix it
@vongosling @RongtongJin hi, i modify test unit by using mock method instead of blocking method. but I'm not sure I'm doing it right. could you review my code?
[https://github.com/apache/rocketmq/pull/2308](https://github.com/apache/rocketmq/pull/2308)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2302: [ISSUE apache#2152] add isRunning method in DefaultLitePullConsumerIm…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302#issuecomment-692654015
[](https://coveralls.io/builds/33470983)
Coverage decreased (-0.1%) to 51.192% when pulling **a26ebe8538558ca1294a9748745d7ef4b57c28c5 on jjz921024:develop** into **2a8ba5a79935ab0a23646455427647ebd57d9e07 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on pull request #2302: [ISSUE #2152] Add isRunning method in DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302#issuecomment-693798643
@RongtongJin @jjz921024 The test seems to be time-consuming. Unit test could use mock style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] jjz921024 commented on pull request #2302: [ISSUE #2152] Add isRunning method in DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
jjz921024 commented on pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302#issuecomment-693878206
> @RongtongJin @jjz921024 The test seems to be time-consuming. Unit test could use mock style.
Copy that, and i also note that, i will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2302: [ISSUE #2152] Add isRunning method in DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2302:
URL: https://github.com/apache/rocketmq/pull/2302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org