You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/27 01:10:39 UTC

[GitHub] [apisix] spacewander commented on issue #4674: Proposal: Addition of an authorization plugin

spacewander commented on issue #4674:
URL: https://github.com/apache/apisix/issues/4674#issuecomment-887133068


   LGTM. There are three minor issues:
   1. `local plugin_name = "apisix-authz"` should be `local plugin_name = "casbin-authz"`
   2. we don't need ` type = 'auth'` as it doesn't interact with consumers
   3. Use underline style name instead of camel case, like `get_policy` but not `getPolicy`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org