You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/03 08:42:58 UTC
[GitHub] [skywalking-nginx-lua] wu-sheng opened a new pull request #11:
Remove 3 `tonumber` to erase the i64 not supported in Lua issue.
wu-sheng opened a new pull request #11: Remove 3 `tonumber` to erase the i64 not supported in Lua issue.
URL: https://github.com/apache/skywalking-nginx-lua/pull/11
int64/long is not supported in LUA, but defined and used in the SkyWalking agents. In this PR, try to keep it as string to avoid the precision loss and formatted as float in scientific notation.
Reported by @arugal , cc @JaredTan95 @dmsolr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-nginx-lua] wu-sheng merged pull request #11: Remove 3
`tonumber` to erase the i64 not supported in Lua issue.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #11: Remove 3 `tonumber` to erase the i64 not supported in Lua issue.
URL: https://github.com/apache/skywalking-nginx-lua/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-nginx-lua] wu-sheng commented on issue #11: Remove 3
`tonumber` to erase the i64 not supported in Lua issue.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #11: Remove 3 `tonumber` to erase the i64 not supported in Lua issue.
URL: https://github.com/apache/skywalking-nginx-lua/pull/11#issuecomment-593837674
cc @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services