You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/02/08 20:23:34 UTC

Review Request 56461: Modify Ranger Hbase Plugin ColumnIterator to use Cell instead of KeyValue (to avoid ClassCastException in certain cases)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56461/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-1365
    https://issues.apache.org/jira/browse/RANGER-1365


Repository: ranger


Description
-------

Modified ColumnIterator to use interface 'Cell' instead of 'KeyValue', a specific subclass of 'Cell'


Diffs
-----

  hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/ColumnIterator.java ccccb4e 
  hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java 5dd727b 
  hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/ColumnIteratorTest.java 4b40038 

Diff: https://reviews.apache.org/r/56461/diff/


Testing
-------

Passed all unit tests including modified test for ColumnIterator.


Thanks,

Abhay Kulkarni


Re: Review Request 56461: Modify Ranger Hbase Plugin ColumnIterator to use Cell instead of KeyValue (to avoid ClassCastException in certain cases)

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56461/#review164953
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Feb. 8, 2017, 8:23 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56461/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 8:23 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1365
>     https://issues.apache.org/jira/browse/RANGER-1365
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Modified ColumnIterator to use interface 'Cell' instead of 'KeyValue', a specific subclass of 'Cell'
> 
> 
> Diffs
> -----
> 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/ColumnIterator.java ccccb4e 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java 5dd727b 
>   hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/ColumnIteratorTest.java 4b40038 
> 
> Diff: https://reviews.apache.org/r/56461/diff/
> 
> 
> Testing
> -------
> 
> Passed all unit tests including modified test for ColumnIterator.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>