You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by gl...@apache.org on 2002/06/29 18:45:08 UTC

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp DelegatingConnection.java

glenn       2002/06/29 09:45:08

  Modified:    dbcp/src/java/org/apache/commons/dbcp
                        DelegatingConnection.java
  Log:
  Fix logic of Connection.isClosed()
  
  Revision  Changes    Path
  1.6       +12 -5     jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java
  
  Index: DelegatingConnection.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DelegatingConnection.java	28 Jun 2002 15:28:20 -0000	1.5
  +++ DelegatingConnection.java	29 Jun 2002 16:45:08 -0000	1.6
  @@ -223,7 +223,14 @@
       public int getTransactionIsolation() throws SQLException { checkOpen(); return _conn.getTransactionIsolation();}
       public Map getTypeMap() throws SQLException { checkOpen(); return _conn.getTypeMap();}
       public SQLWarning getWarnings() throws SQLException { checkOpen(); return _conn.getWarnings();}
  -    public boolean isClosed() throws SQLException { return _closed || _conn.isClosed();}
  +
  +    public boolean isClosed() throws SQLException {
  +         if(_closed || _conn.isClosed()) {
  +             return true;
  +         }
  +         return false;
  +    }
  +
       public boolean isReadOnly() throws SQLException { checkOpen(); return _conn.isReadOnly();}
       public String nativeSQL(String sql) throws SQLException { checkOpen(); return _conn.nativeSQL(sql);}
       public void rollback() throws SQLException { checkOpen(); _conn.rollback();}
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp DelegatingConnection.java

Posted by John McNally <jm...@collab.net>.
What does this accomplish?

john mcnally

On Sat, 2002-06-29 at 09:45, glenn@apache.org wrote:
> glenn       2002/06/29 09:45:08
> 
>   Modified:    dbcp/src/java/org/apache/commons/dbcp
>                         DelegatingConnection.java
>   Log:
>   Fix logic of Connection.isClosed()
>   
>   Revision  Changes    Path
>   1.6       +12 -5     jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java
>   
>   Index: DelegatingConnection.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java,v
>   retrieving revision 1.5
>   retrieving revision 1.6
>   diff -u -r1.5 -r1.6
>   --- DelegatingConnection.java	28 Jun 2002 15:28:20 -0000	1.5
>   +++ DelegatingConnection.java	29 Jun 2002 16:45:08 -0000	1.6
>   @@ -223,7 +223,14 @@
>        public int getTransactionIsolation() throws SQLException { checkOpen(); return _conn.getTransactionIsolation();}
>        public Map getTypeMap() throws SQLException { checkOpen(); return _conn.getTypeMap();}
>        public SQLWarning getWarnings() throws SQLException { checkOpen(); return _conn.getWarnings();}
>   -    public boolean isClosed() throws SQLException { return _closed || _conn.isClosed();}
>   +
>   +    public boolean isClosed() throws SQLException {
>   +         if(_closed || _conn.isClosed()) {
>   +             return true;
>   +         }
>   +         return false;
>   +    }
>   +
>        public boolean isReadOnly() throws SQLException { checkOpen(); return _conn.isReadOnly();}
>        public String nativeSQL(String sql) throws SQLException { checkOpen(); return _conn.nativeSQL(sql);}
>        public void rollback() throws SQLException { checkOpen(); _conn.rollback();}
>   
>   
>   
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>