You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:54:42 UTC
[GitHub] [fineract] nnatarajan opened a new pull request #1021: FINERACT-1029 Failing lint test for static
nnatarajan opened a new pull request #1021:
URL: https://github.com/apache/fineract/pull/1021
## Description
@vorburger
From the static lint check, it appears that the variables created are not being used.
It is ok to delete the variables?
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643829943
@vorburger , resolved the merge conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643796031
Bulk changes for mass reformatting are now fully completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643756001
@nnatarajan would you be willing to resolve the merge conflicts which now appear here? Thanks! (It's just due to us having meanwhile merged other PRs; this sometimes happens when we work in parallel, and is somewhat unavoidable.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643795867
@vorburger
How frustrating! Both checks passed on GitHub yesterday, earning Xurror ok.
I was concerned that this would not get merged in time.
It seems with all the bulk changes today have resulted in merge conflicts, which will continue until completed.
Please let me know when the bulk changes are complete, then it will make sense to redo the 500 changes on my end.
I am hoping that I can revisit and resolve this tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643795867
@vorburger
How frustrating! Both checks passed on GitHub yesterday, earning xurror ok.
I was concerned that this would not get merged in time.
It seems with all the bulk changes today have resulted in merge conflicts, which will continue until completed.
Please let me know when the bulk changes are complete, then it will make sense to redo the 500 changes on my end.
I am hoping that I can revisit and resolve this tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643795867
@vorburger
How frustrating! Both checks passed on GitHub yesterday, earning XUROR ok.
I was concerned that this would not get merged in time.
It seems with all the bulk changes today have resulted in merge conflicts, which will continue until completed.
Please let me know when the bulk changes are complete, then it will make sense to redo the 500 changes on my end.
I am hoping that I can revisit and resolve this tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1021:
URL: https://github.com/apache/fineract/pull/1021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #1021: FINERACT-1029 Failing lint test for static
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #1021:
URL: https://github.com/apache/fineract/pull/1021#issuecomment-643795867
@vorburger
How frustrating! Both checks passed on GitHub yesterday, earning XUROR ok.
I was concerned that this would not get merged in time.
It seems with all the bulk changes today have resulted in merge conflicts, which will continue until completed.
Please let me know when the bulk changes are complete, then it will make sense to redo the 500 changes on my end.
I am hoping that I can revisit and resolve this tomorrow to resolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org