You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2014/08/21 01:05:14 UTC

[GitHub] spark pull request: [SPARK-3133] Piggyback control message to fetc...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/2069

    [SPARK-3133] Piggyback control message to fetch small block for TorrentBroadcast

    This reduces the number of network calls from 3 to 1 for small broadcasts, which should improve small task scheduling latency.
    
    Slightly ugly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark piggyback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2069.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2069
    
----
commit 7e9fe7bbefae3a81fdb94dc4fdf11ffca9cbdf18
Author: Reynold Xin <rx...@apache.org>
Date:   2014-08-20T23:03:59Z

    [SPARK-3133] Piggyback control message to fetch small block for TorrentBroadcast.
    
    This reduces the number of network calls from 3 to 1 for small broadcasts, which should improve small task scheduling latency.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3133] Piggyback control message to fetc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2069#issuecomment-54698614
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19868/consoleFull) for   PR 2069 at commit [`7e9fe7b`](https://github.com/apache/spark/commit/7e9fe7bbefae3a81fdb94dc4fdf11ffca9cbdf18).
     * This patch **fails** unit tests.
     * This patch **does not** merge cleanly!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3133] Piggyback control message to fetc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2069#issuecomment-54695090
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19868/consoleFull) for   PR 2069 at commit [`7e9fe7b`](https://github.com/apache/spark/commit/7e9fe7bbefae3a81fdb94dc4fdf11ffca9cbdf18).
     * This patch **does not** merge cleanly!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3133] Piggyback control message to fetc...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/2069#issuecomment-58099321
  
    Closing this one in favor of #2681


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3133] Piggyback control message to fetc...

Posted by rxin <gi...@git.apache.org>.
Github user rxin closed the pull request at:

    https://github.com/apache/spark/pull/2069


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org