[GitHub] [mynewt-core] andrzej-kaczmarek commented on a change in pull request #1802: hw/mcu/dialog: Enable DCDC only when VBAT is OK

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #1802: hw/mcu/dialog: Enable DCDC only when VBAT is OK
URL: https://github.com/apache/mynewt-core/pull/1802#discussion_r282025701
 
 

 ##########
 File path: hw/mcu/dialog/da1469x/src/system_da1469x.c
 ##########
 @@ -110,7 +110,13 @@ void SystemInit(void)
     /* Initialize and configure power rails */
     da1469x_prail_initialize();
 #if MYNEWT_VAL(MCU_DCDC_ENABLE)
-    da1469x_prail_dcdc_enable();
+    /*
+     * Enabling DCDC while VBAT is below 2.5 V renders system unstable even
+     * if VBUS is available. Enable DCDC only if VBAT is above minimal value.
+     */
+    if (CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_COMP_VBAT_HIGH_Msk) {
+        da1469x_prail_dcdc_enable();
 
 Review comment:
   this also stores dcdc registers in retregs to be restored when going out of deep sleep so probably what we should do is to split this call to be able to configure dcdc and enable/disable depending on VBAT state

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services