You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2026/01/21 08:51:27 UTC
[PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
peter-toth opened a new pull request, #53884:
URL: https://github.com/apache/spark/pull/53884
### What changes were proposed in this pull request?
This is a minor fix of `EnsureRequirements` to make sure copied scan nodes inherit the tags from original ones in SPJ functions.
### Why are the changes needed?
Fis possible bugs.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth closed pull request #53884: [SPARK-55113][SQL] `EnsureRequirements` should copy tags
URL: https://github.com/apache/spark/pull/53884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #53884:
URL: https://github.com/apache/spark/pull/53884#issuecomment-3780801825
> Can we add a test if possible?
Unfortunately, I don't have any concrete tests that exposes the bug with not copying the tags in `populateCommonPartitionInfo()` or in `populateJoinKeyPositions()`.
But this issue came up at https://github.com/apache/spark/pull/53859#discussion_r2707992946 where a very similar `populateNoGroupingPartitionInfo()` is added and if it doesn't copy the tags the missing logical link tag causes trouble in some AQE tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #53884:
URL: https://github.com/apache/spark/pull/53884#issuecomment-3783063827
Thanks for the review! Merged to `master` (4.2.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #53884:
URL: https://github.com/apache/spark/pull/53884#issuecomment-3777379290
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55113][SQL] `EnsureRequirements` should copy tags [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53884:
URL: https://github.com/apache/spark/pull/53884#issuecomment-3776885514
## JIRA Issue Information
=== Bug SPARK-55113 ===
Summary: EnsureRequirements should copy tags
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org