You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/04/08 15:52:44 UTC

[GitHub] [hive] pvary commented on a change in pull request #2161: WIP: HIVE-XXX: Move Iceberg job commit to HS2 side

pvary commented on a change in pull request #2161:
URL: https://github.com/apache/hive/pull/2161#discussion_r609847726



##########
File path: iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -250,4 +259,43 @@ private static PartitionSpec spec(Schema schema, Properties properties,
       return PartitionSpec.unpartitioned();
     }
   }
+
+  @Override
+  public void commitInsertTable(org.apache.hadoop.hive.metastore.api.Table table, boolean overwrite)
+      throws MetaException {
+    // construct the job context
+    JobConf jobConf = new JobConf(conf);
+    String tableName = TableIdentifier.of(table.getDbName(), table.getTableName()).toString();

Review comment:
       How this will get the `Catalog` information?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org