[GitHub] [arrow-rs] JayjeetAtGithub commented on a diff in pull request #3514: Use array_value_to_string in arrow-csv

["JayjeetAtGithub (via GitHub)" <gi...@apache.org>]

JayjeetAtGithub commented on code in PR #3514:
URL: https://github.com/apache/arrow-rs/pull/3514#discussion_r1083321202


##########
arrow-csv/src/writer.rs:
##########
@@ -430,33 +364,45 @@ impl WriterBuilder {
         self
     }
 
+    /// Whether to use RFC3339 format for date/time/timestamps
+    pub fn with_rfc3339(mut self, use_rfc3339: bool) -> Self {
+        self.use_rfc3339 = use_rfc3339;

Review Comment:
   I agree. I am also thinking if the user first uses `with_rfc3339` and then `with_date_format`, then the later will override the former, and it might also be confusing?! We would probably need to explain this behavior properly in the API docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org