You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 21:44:25 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13735: fix(#13734): Properly escape special characters in CSV output
codecov[bot] commented on pull request #13735:
URL: https://github.com/apache/superset/pull/13735#issuecomment-804416121
# [Codecov](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=h1) Report
> Merging [#13735](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=desc) (6e5d922) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `0.28%`.
> The diff coverage is `94.73%`.
> :exclamation: Current head 6e5d922 differs from pull request most recent head 8414c47. Consider uploading reports for the commit 8414c47 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13735 +/- ##
==========================================
- Coverage 77.43% 77.14% -0.29%
==========================================
Files 933 934 +1
Lines 47093 47076 -17
Branches 5818 5818
==========================================
- Hits 36465 36318 -147
- Misses 10485 10615 +130
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.57% <94.73%> (+0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.57% <94.73%> (-0.54%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.16% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/utils/csv.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY3N2LnB5) | `100.00% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.49%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/13735/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=footer). Last update [aa92c1e...8414c47](https://codecov.io/gh/apache/superset/pull/13735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org