[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #13936: [Improvement][API Test] Add API tests for worker group related APIs

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #13936:
URL: https://github.com/apache/dolphinscheduler/pull/13936#discussion_r1169388341


##########
dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/resources/docker/basic/docker-compose.yaml:
##########
@@ -26,12 +26,18 @@ services:
     ports:
       - "12345:12345"
     networks:
-      - api-test
+      network:
+        ipv4_address: 10.5.0.5
     healthcheck:
       test: [ "CMD", "curl", "http://localhost:12345/actuator/health" ]
       interval: 5s
       timeout: 60s
       retries: 120
 
 networks:
-  api-test:
+  network:
+    driver: bridge
+    ipam:
+      config:
+        - subnet: 10.5.0.0/16
+          gateway: 10.5.0.1

Review Comment:
   Why do we need this?



##########
dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api.test/cases/TenantAPITest.java:
##########
@@ -79,7 +79,7 @@ public void testDuplicateCreateTenant() {
 
         HttpResponse createTenantHttpResponse = tenantPage.createTenant(sessionId, tenant, 1, "");
 
-        Assertions.assertFalse(createTenantHttpResponse.body().success());
+        Assertions.assertFalse(createTenantHttpResponse.getBody().getSuccess());

Review Comment:
   Do you think `getBody()` is neater than `body()` 😉



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org