You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by ctubbsii <gi...@git.apache.org> on 2017/02/08 04:37:44 UTC
[GitHub] accumulo pull request #214: ACCUMULO-4551 thrift 0.10.0
GitHub user ctubbsii opened a pull request:
https://github.com/apache/accumulo/pull/214
ACCUMULO-4551 thrift 0.10.0
This PR includes changes to update thrift, but without any re-generated Java code. For that, see the next PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4551-thrift-0.10.0-nogen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #214
----
commit 6fedc1f382caade17c6e05e5e74af832709beaf5
Author: Christopher Tubbs <ct...@apache.org>
Date: 2017-02-05T04:49:23Z
Update to thrift 0.10.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #214: ACCUMULO-4551 thrift 0.10.0
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/214
I ran all the ITs with 0.10.0, and everything passed. (Some unstable tests had to be re-run, but their stability is unrelated to thrift version.) I'm going to merge this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #214: ACCUMULO-4551 thrift 0.10.0
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/214
@keith-turner No, only `-Psunny`, which passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #214: ACCUMULO-4551 thrift 0.10.0
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/214
I remember we had to add some special handling for TApplicationException when going from 0.9.1 to 0.9.3. I wonder if this is still needed. It would be useful to find some ITs that expect AccumuloServerException and see if those are still working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #214: ACCUMULO-4551 thrift 0.10.0
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/214
@ctubbsii did you try running all of the ITs for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #214: ACCUMULO-4551 thrift 0.10.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #214: ACCUMULO-4551 thrift 0.10.0
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/214
@keith-turner I believe it still is needed, but some of the stuff we may have done to handle exceptions on oneway methods might no longer be needed. I saw some changes in the exception handling in the generated code for that. Feel free to review it. @joshelser may also have some insight (I believe he fixed the oneway issue previously, but I can't find the ticket).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---