You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/17 20:01:51 UTC

[GitHub] [spark] EnricoMi commented on pull request #37211: [SPARK-39644][SQL][WIP] Add RangePartitioning reporting for V2 DataSources

EnricoMi commented on PR #37211:
URL: https://github.com/apache/spark/pull/37211#issuecomment-1186598134

   @sunchao here is the `RangePartitioning`. Tests show that data sources that report this partitioning avoid shuffle and sorting for supported right transformations.
   
   The `RangePartitioning` is derived from `KeyGroupedPartitioning`, because it as well partitions by the sort keys, while in addition the keys are sorted.
   
   Do you agree adding `rangePartitioning` to `DataSourceV2ScanRelation` and `DataSourceV2ScanExecBase` is the right thing, or should those `SortOrder` expressions be used as `keyGroupedPartitioning` instead and taken by `DataSourceV2Strategy` from there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org