You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/21 00:08:44 UTC
[GitHub] [incubator-doris] WillemJiang commented on a change in pull request #4371: [License] Organize and modify the license of the code
WillemJiang commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474335521
##########
File path: build.sh
##########
@@ -140,6 +124,13 @@ if [ ${CLEAN} -eq 1 -a ${BUILD_BE} -eq 0 -a ${BUILD_FE} -eq 0 -a ${BUILD_SPARK_D
exit 1
fi
+if [[ -z ${WITH_MYSQL} ]]; then
Review comment:
Just a quick question how can we enable the build with MYSQL?
##########
File path: docs/en/README.md
##########
@@ -74,3 +74,23 @@ cases:
actionText: Quick Start →
actionLink: /en/installing/compilation
---
+
Review comment:
Do we need to add the License header on the markdown file?
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
建议前面依赖库前面 加一个 “移除”。
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
建议前面依赖库前面 加一个 “移除”。
还有就是依赖库[1] 应该是MySQL client吧！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org