You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/27 11:41:22 UTC
[GitHub] [incubator-doris] xy720 opened a new pull request #4470: [Spark Load] Redirect the spark launcher's log to a separated log file
xy720 opened a new pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470
## Proposed changes
#4469
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] New feature (non-breaking change which adds functionality)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4470: [Spark Load] Redirect the spark launcher's log to a separated log file
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xy720 commented on a change in pull request #4470: [Spark Load] Redirect the spark launcher's log to a separated log file
Posted by GitBox <gi...@apache.org>.
xy720 commented on a change in pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470#discussion_r478811509
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##########
@@ -701,6 +702,20 @@ protected long getEtlStartTimestamp() {
return etlStartTimestamp;
}
+ public SparkLoadAppHandle getHandle() {
+ return sparkLoadAppHandle;
+ }
+
+ public void clearSparkLauncherLog() {
+ String logPath = sparkLoadAppHandle.getLogPath();
Review comment:
Not sure. So I made a new check here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xy720 commented on a change in pull request #4470: [Spark Load] Redirect the spark launcher's log to a separated log file
Posted by GitBox <gi...@apache.org>.
xy720 commented on a change in pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470#discussion_r478811398
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLauncherMonitor.java
##########
@@ -103,7 +114,7 @@ public void run() {
try {
outReader = new BufferedReader(new InputStreamReader(process.getInputStream()));
while (!isStop && (line = outReader.readLine()) != null) {
- LOG.info("monitor log: " + line);
+ outputBuffer.append(line + '\n');
Review comment:
ok. I changed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4470: [Spark Load] Redirect the spark launcher's log to a separated log file
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470#discussion_r478522918
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLauncherMonitor.java
##########
@@ -103,7 +114,7 @@ public void run() {
try {
outReader = new BufferedReader(new InputStreamReader(process.getInputStream()));
while (!isStop && (line = outReader.readLine()) != null) {
- LOG.info("monitor log: " + line);
+ outputBuffer.append(line + '\n');
Review comment:
why not just output to the `outputStream`? So that we don't need to buffer a log of content in memory?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##########
@@ -701,6 +702,20 @@ protected long getEtlStartTimestamp() {
return etlStartTimestamp;
}
+ public SparkLoadAppHandle getHandle() {
+ return sparkLoadAppHandle;
+ }
+
+ public void clearSparkLauncherLog() {
+ String logPath = sparkLoadAppHandle.getLogPath();
Review comment:
Are you sure the `sparkLoadAppHandle` is not null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org