You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/05/24 13:20:04 UTC

[GitHub] [flink] XComp opened a new pull request, #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

XComp opened a new pull request, #22642:
URL: https://github.com/apache/flink/pull/22642

   ## What is the purpose of the change
   
   `Collection<LeaderInformationWithComponentId>` can be represented using a Map as well. This allows us to remove LeaderInformationWithComponentId to reduce the redundant struct classes around `LeaderInformation` (e.g. `LeaderInformation`, `LeaderConnectionInfo`, `LeaderInformationWithComponentId`).
   
   There is no real need to support having different leader information per contender ID (which would be the only reason why we want a `Collection` instead of a `Map`).
   
   ## Brief change log
   
   * Refactors interface
   
   ## Verifying this change
   
   * Tests were refactored analogously and should run without problems.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22642:
URL: https://github.com/apache/flink/pull/22642#issuecomment-1594427607

   This checkstyle stuff is sometimes annoying -.- Anyway, I fixed it and rebased the branch to master after FLINK-31781 was merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22642:
URL: https://github.com/apache/flink/pull/22642#issuecomment-1561155842

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aff6c1ada04a5b25facff7958e52d16bac9b775b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aff6c1ada04a5b25facff7958e52d16bac9b775b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aff6c1ada04a5b25facff7958e52d16bac9b775b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #22642:
URL: https://github.com/apache/flink/pull/22642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22642:
URL: https://github.com/apache/flink/pull/22642#issuecomment-1591155371

   Rebased on FLINK-31781 to include the libssl fix from master and the format fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22642: [FLINK-32177][runtime] Refactors MultipleComponentLeaderElectionDriver.Listener.notifyAllKnownLeaderInformation signature

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22642:
URL: https://github.com/apache/flink/pull/22642#issuecomment-1592975146

   I rebased on most recent version of FLINK-31781 after that was approved to fix the conflicts.
   
   > ehhhh LeaderInformationWithComponentId is more expressive though ("What is that String key?"). Maybe we should wrap the map instead, we arent doing a lot with the map anyway.
   
   I added a commit that introduced `LeaderInformationRegister` wrapping the `Map` with the `contenderID` to `LeaderInformation` mapping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org