You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2007/08/22 15:34:31 UTC
[jira] Created: (LUCENENET-86) Nunit test for TestSort.
Nunit test for TestSort.
------------------------
Key: LUCENENET-86
URL: https://issues.apache.org/jira/browse/LUCENENET-86
Project: Lucene.Net
Issue Type: Bug
Reporter: Digy
Priority: Minor
Attachments: FieldDocSortedHitQueue.patch
There are two bugs in FieldDocSortedHitQueue.LessThan method
1- in "case SortField.FLOAT:"
The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
RE: unsubscribe
Posted by BalKrishna Jha <ba...@BIRLASOFT.COM>.
-----Original Message-----
From: Kip Hughes [mailto:kiphughes@gmail.com]
Sent: Thursday, August 23, 2007 1:32 AM
To: lucene-net-dev@incubator.apache.org
Subject: Re: unsubscribe
Unsubscribe
*********************************************************************************************************************************************************************
"This message and any attachments are solely for the intended recipient and may contain Birlasoft confidential or privileged information. If you are not the intended recipient,any disclosure,copying, use, or distribution of the information included in this message and any attachments is
prohibited. If you have received this communication in error, please notify us by reply e-mail(administrator@birlasoft.com)and immediately and permanently delete this message and any attachments. Thank you."
*********************************************************************************************************************************************************************
Re: unsubscribe
Posted by Kip Hughes <ki...@gmail.com>.
Unsubscribe
unsubscribe
Posted by Atali DAOUD <at...@gmail.com>.
Unsubscribe
unsubscribe
Posted by Sergiy Savchenko <ma...@gmail.com>.
Unsubscribe
unsubscribe
Posted by Christian Carollo <Ch...@fandango.com>.
Unsubscribe
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521998 ]
George Aroush commented on LUCENENET-86:
----------------------------------------
Hi Digy,
In my case, those two test cases will pass, with or without the patch. Did you mean another test case?
Regards,
-- George
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-86:
--------------------------
Attachment: TestSort.patch
This patch invalidates the previous one and has a localized test data.
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: Screenshot.JPG, TestSort.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521824 ]
George Aroush commented on LUCENENET-86:
----------------------------------------
Hi Digy,
Which NUnit test is this patch addressing?
Regards,
-- George
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-86:
--------------------------
Attachment: (was: FieldDocSortedHitQueue.patch)
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: Screenshot.JPG, TestSort.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522180 ]
George Aroush commented on LUCENENET-86:
----------------------------------------
Hi Digy,
I too grabbed a fresh copy from SVN and re-run this sub-test, with and without the patch and the test will pass in both cases.
What local are you on? Is it possible this is more of an issue with parsing ".", vs. ","? Also, in the call stack that you provided, what line in the file FieldDocSortedHitQueue.cs is the exception of type InvalidCastException occurring?
My concern with this patch is that it is adding new logic to the Lucene.Net code which will diverge it from the Java version. In addition, I have not been able to understand the defect the patch is trying to solve, and that I can't reproduce it.
Regards,
-- George
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch, Screenshot.JPG
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522052 ]
Digy commented on LUCENENET-86:
-------------------------------
Hi George,
I downloaded the new patches, started with a "clean" lucene.net version and again two test cases failed. After i applied the patch i sent, they passed.
Without the patch i get the following error.
System.InvalidCastException: Specified cast is not valid.
and StackTrace:
at Lucene.Net.Search.FieldDocSortedHitQueue.LessThan(Object a, Object b)
at Lucene.Net.Util.PriorityQueue.UpHeap()
at Lucene.Net.Util.PriorityQueue.Insert(Object element)
at Lucene.Net.Search.MultiSearcher.Search(Weight weight, Filter filter, Int32 n, Sort sort)
at Lucene.Net.Search.Hits.GetMoreDocs(Int32 min)
at Lucene.Net.Search.Hits..ctor(Searcher s, Query q, Filter f, Sort o)
at Lucene.Net.Search.Searcher.Search(Query query, Sort sort)
at Lucene.Net.Search.TestSort.AssertMatchesPattern(Searcher searcher, Query query, Sort sort, String pattern)
at Lucene.Net.Search.TestSort.RunMultiSorts(Searcher multi)
at Lucene.Net.Search.TestSort.TestMultiSort()
DIGY
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush resolved LUCENENET-86.
------------------------------------
Resolution: Fixed
Applied patch and delivered to 2.1
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Screenshot.JPG, TestSort.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-86:
--------------------------
Attachment: FieldDocSortedHitQueue.patch
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522192 ]
Digy commented on LUCENENET-86:
-------------------------------
Hi George,
case SortField.FLOAT:
float f1 = (float)((System.Single)docA.fields[i]); <------ Bug
float f2 = (float)((System.Single)docB.fields[i]);
1- Since the content of docA.fields[i] appears to be a string, it causes a TypeCast exception. therefore i check its type in the patch and if it is a string i convert it to float.
2- After fixing the above bug, the problem docA.fields[i]==null arises. this needs another fix.
As you say, maybe it is a ".", vs. "," issue, coming out from somewhere else.
DIGY
Oooops,
***** After 5 minutes i wrote above message, i discovered that the sample data in TestSort.cs contains floats with "."s not with ","s. Replacing dots with commas solved the problem.
So, patch can wait, but i think i will be needed sometime.
DIGY
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch, Screenshot.JPG
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521837 ]
Digy commented on LUCENENET-86:
-------------------------------
Hi George,
It is related with
Search/TestSort/TestMultiSort and Search/TestSort/TestParallelMultiSort
DIGY
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-86) Nunit test for TestSort.
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-86:
--------------------------
Attachment: Screenshot.JPG
I attach the screen shot for that test
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FieldDocSortedHitQueue.patch, Screenshot.JPG
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush closed LUCENENET-86.
----------------------------------
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Screenshot.JPG, TestSort.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (LUCENENET-86) Nunit test for TestSort.
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush reassigned LUCENENET-86:
--------------------------------------
Assignee: George Aroush
> Nunit test for TestSort.
> ------------------------
>
> Key: LUCENENET-86
> URL: https://issues.apache.org/jira/browse/LUCENENET-86
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Screenshot.JPG, TestSort.patch
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1- in "case SortField.FLOAT:"
> The value of docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.