[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351552#comment-16351552 ] 

ASF GitHub Bot commented on TINKERPOP-1883:
-------------------------------------------

GitHub user dancollins34 opened a pull request:

    https://github.com/apache/tinkerpop/pull/796

    Added correct setting of future exceptions, pursuant to TINKERPOP-1883

    https://issues.apache.org/jira/browse/TINKERPOP-1883

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dancollins34/tinkerpop master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #796
    
----
commit 2257d951ebc11de3b3bd13c93417c970c3d5c182
Author: dancollins34 <da...@...>
Date:   2018-02-03T22:24:44Z

    Added correct setting of future exceptions, pursuant to TINKERPOP-1883
    
    https://issues.apache.org/jira/browse/TINKERPOP-1883

----


> gremlinpython future will never return
> --------------------------------------
>
>                 Key: TINKERPOP-1883
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1883
>             Project: TinkerPop
>          Issue Type: Bug
>    Affects Versions: 3.3.1
>         Environment: all
>            Reporter: Daniel Collins
>            Priority: Major
>
> When using the promise() method to get a future from a traversal, a call to result() will never return if an error is thrown by result_set.all().result() in driver_remote_connection.py on line 69. This call should be wrapped in a try block to set the exception of future on failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)