You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hermanschaaf (via GitHub)" <gi...@apache.org> on 2023/04/18 18:15:13 UTC
[GitHub] [arrow] hermanschaaf opened a new pull request, #35215: Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
hermanschaaf opened a new pull request, #35215:
URL: https://github.com/apache/arrow/pull/35215
This adds support for printing the full call stack when a leak is reported by the checked memory allocator. An `ARROW_CHECKED_MAX_RETAINED_FRAMES` environment variable controls how many frames are retained. To keep this completely backwards-compatible, the default right now is zero. In this case, the reported error is exactly the same as before. When a higher value is given though, a longer call stack is printed. For example:
Before (same as `ARROW_CHECKED_MAX_RETAINED_FRAMES=0`):
```
checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396
```
After (with `ARROW_CHECKED_MAX_RETAINED_FRAMES=100`):
```
checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396
github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewTimestampArray line 2386
github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewArray line 2380
github.com/apache/arrow/go/v12/arrow/array.(*RecordBuilder).NewRecord line 346
github.com/cloudquery/plugin-sdk/v2/testdata.GenTestData line 243
github.com/cloudquery/plugin-sdk/v2/plugins/destination.testMigration line 53
github.com/cloudquery/plugin-sdk/v2/plugins/destination.(*PluginTestSuite).destinationPluginTestMigrate.func5 line 239
testing.tRunner line 1576
runtime.goexit line 1172
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35215: GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35215:
URL: https://github.com/apache/arrow/pull/35215#issuecomment-1513606146
* Closes: #35212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35215: GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35215:
URL: https://github.com/apache/arrow/pull/35215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35215: GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35215:
URL: https://github.com/apache/arrow/pull/35215#issuecomment-1516574200
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/70a4335d17704addb85ff30ab4727f9f...ba0a051acae543338c19a8439f3510d7/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35215: GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35215:
URL: https://github.com/apache/arrow/pull/35215#issuecomment-1516573111
Benchmark runs are scheduled for baseline = 16bd95fd534312743cfeb4b6e8090ca82f49c2f6 and contender = 7a7b414d1fd0d648a6d248fb1bbe1984e9585480. 7a7b414d1fd0d648a6d248fb1bbe1984e9585480 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1e232c50309d42bba9858c9b4144dd50...00308fe36b8645b2890ec1e999722444/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ec7eef7bc73f4d5588276e2a4520e528...a7371272b27243c89f6431507ee8dc76/)
[Finished :arrow_down:9.18% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/70a4335d17704addb85ff30ab4727f9f...ba0a051acae543338c19a8439f3510d7/)
[Finished :arrow_down:0.42% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4039c901e16a43baaaa22d0cfa93ac4c...4a0588a3fb0d424aaf026279589a01e8/)
Buildkite builds:
[Finished] [`7a7b414d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2746)
[Failed] [`7a7b414d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2780)
[Finished] [`7a7b414d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2744)
[Finished] [`7a7b414d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2771)
[Finished] [`16bd95fd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2745)
[Failed] [`16bd95fd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2779)
[Finished] [`16bd95fd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2743)
[Finished] [`16bd95fd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2770)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35215: GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35215:
URL: https://github.com/apache/arrow/pull/35215#issuecomment-1513606206
:warning: GitHub issue #35212 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org