You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/01/19 16:29:52 UTC
[PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
zclllyybb opened a new pull request, #60042:
URL: https://github.com/apache/doris/pull/60042
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3773249835
# BE UT Coverage Report
Increment line coverage `47.37% (9/19)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/03c8e3336f3e2d41ebe33618c694226b361ed75f_03c8e3336f3e2d41ebe33618c694226b361ed75f/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/03c8e3336f3e2d41ebe33618c694226b361ed75f_03c8e3336f3e2d41ebe33618c694226b361ed75f/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.43% (19055/36343) |
| Line Coverage | 35.72% (176455/494055) |
| Region Coverage | 32.27% (136702/423597) |
| Branch Coverage | 33.16% (59087/178179) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3769224638
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3769683855
<details>
<summary>TPC-DS: <b>Total hot run time: 174757 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c921cedae171d93a9d086347810f519f4cfe487b, data reload: false
query5 4422 620 467 467
query6 348 223 204 204
query7 4223 458 258 258
query8 348 259 249 249
query9 8703 2934 2934 2934
query10 462 393 322 322
query11 15263 15092 15029 15029
query12 180 118 119 118
query13 1255 488 369 369
query14 5588 3035 2770 2770
query14_1 2655 2641 2637 2637
query15 205 194 173 173
query16 975 497 467 467
query17 935 657 567 567
query18 2435 447 332 332
query19 229 213 190 190
query20 122 116 113 113
query21 213 140 122 122
query22 4110 4325 4297 4297
query23 16262 15834 15443 15443
query23_1 15534 15779 15496 15496
query24 7167 1583 1203 1203
query24_1 1169 1160 1180 1160
query25 539 451 403 403
query26 1239 269 157 157
query27 2756 447 290 290
query28 4540 2197 2189 2189
query29 755 537 435 435
query30 312 243 207 207
query31 815 635 566 566
query32 87 80 72 72
query33 531 357 325 325
query34 897 881 536 536
query35 724 755 690 690
query36 856 897 838 838
query37 136 104 89 89
query38 2804 2707 2648 2648
query39 773 745 724 724
query39_1 723 720 714 714
query40 218 156 124 124
query41 72 68 71 68
query42 107 106 104 104
query43 468 478 450 450
query44 1355 756 751 751
query45 190 196 182 182
query46 839 1003 584 584
query47 1449 1488 1392 1392
query48 314 315 238 238
query49 600 424 346 346
query50 622 260 199 199
query51 3704 3755 3735 3735
query52 104 105 93 93
query53 281 323 270 270
query54 291 263 256 256
query55 83 82 76 76
query56 308 308 293 293
query57 1056 1040 959 959
query58 262 252 259 252
query59 2142 2149 2128 2128
query60 335 353 312 312
query61 150 151 148 148
query62 383 347 310 310
query63 295 266 269 266
query64 4927 1241 948 948
query65 3835 3765 3803 3765
query66 1465 409 322 322
query67 15507 15498 15452 15452
query68 2383 1094 761 761
query69 493 357 322 322
query70 1015 913 935 913
query71 320 310 290 290
query72 5210 3094 3254 3094
query73 612 731 314 314
query74 8760 8747 8569 8569
query75 2748 2782 2466 2466
query76 2244 1081 658 658
query77 369 377 308 308
query78 9692 10015 9237 9237
query79 1052 931 577 577
query80 1293 571 483 483
query81 535 266 230 230
query82 1003 144 112 112
query83 325 250 239 239
query84 296 112 85 85
query85 878 482 420 420
query86 410 330 334 330
query87 2841 2936 2749 2749
query88 3462 2602 2585 2585
query89 391 337 332 332
query90 1998 170 165 165
query91 172 164 132 132
query92 77 75 74 74
query93 968 892 554 554
query94 643 324 303 303
query95 588 395 318 318
query96 641 501 232 232
query97 2325 2368 2291 2291
query98 215 199 193 193
query99 624 587 531 531
Total cold run time: 246839 ms
Total hot run time: 174757 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3776615488
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3769696018
<details>
<summary>ClickBench: <b>Total hot run time: 26.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c921cedae171d93a9d086347810f519f4cfe487b, data reload: false
query1 0.05 0.04 0.04
query2 0.10 0.04 0.04
query3 0.27 0.08 0.08
query4 1.62 0.11 0.11
query5 0.28 0.26 0.26
query6 1.14 0.66 0.66
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.57 0.50 0.50
query10 0.55 0.54 0.53
query11 0.15 0.09 0.10
query12 0.14 0.11 0.11
query13 0.60 0.59 0.58
query14 0.94 0.93 0.94
query15 0.79 0.77 0.78
query16 0.39 0.40 0.39
query17 1.02 1.00 1.00
query18 0.23 0.21 0.21
query19 1.90 1.78 1.83
query20 0.03 0.01 0.01
query21 15.45 0.28 0.14
query22 4.91 0.06 0.04
query23 15.72 0.30 0.09
query24 2.22 0.29 0.18
query25 0.12 0.08 0.08
query26 0.14 0.14 0.13
query27 0.08 0.04 0.04
query28 4.42 1.08 0.88
query29 12.55 3.92 3.13
query30 0.28 0.14 0.12
query31 2.81 0.64 0.40
query32 3.24 0.57 0.45
query33 2.97 3.01 2.97
query34 16.22 5.06 4.41
query35 4.45 4.41 4.41
query36 0.66 0.51 0.50
query37 0.10 0.06 0.06
query38 0.08 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 97.65 s
Total hot run time: 26.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3769656898
<details>
<summary>TPC-H: <b>Total hot run time: 31952 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c921cedae171d93a9d086347810f519f4cfe487b, data reload: false
------ Round 1 ----------------------------------
q1 17670 4182 4077 4077
q2 2075 351 239 239
q3 10150 1303 739 739
q4 10236 852 302 302
q5 7841 2132 1880 1880
q6 226 173 139 139
q7 918 798 663 663
q8 9262 1375 1111 1111
q9 4902 4603 4604 4603
q10 6804 1824 1377 1377
q11 529 299 286 286
q12 755 747 636 636
q13 17839 3806 3086 3086
q14 296 307 269 269
q15 597 517 508 508
q16 690 707 638 638
q17 902 806 469 469
q18 6721 6466 7031 6466
q19 2020 1044 660 660
q20 422 362 268 268
q21 3255 2895 2523 2523
q22 1135 1086 1013 1013
Total cold run time: 105245 ms
Total hot run time: 31952 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4460 4373 4272 4272
q2 326 404 346 346
q3 2271 2752 2448 2448
q4 1400 1925 1420 1420
q5 4636 4351 4242 4242
q6 223 183 134 134
q7 1958 1960 1782 1782
q8 2684 2568 2384 2384
q9 7155 7230 7250 7230
q10 2438 2648 2267 2267
q11 558 494 459 459
q12 684 743 590 590
q13 3302 3803 3130 3130
q14 279 280 264 264
q15 522 486 482 482
q16 602 652 620 620
q17 1123 1297 1358 1297
q18 7491 7289 7358 7289
q19 813 799 819 799
q20 1879 1978 1768 1768
q21 4508 4222 4211 4211
q22 1047 1045 967 967
Total cold run time: 50359 ms
Total hot run time: 48401 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3772315724
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3776615606
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3772842664
<details>
<summary>TPC-DS: <b>Total hot run time: 173987 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03c8e3336f3e2d41ebe33618c694226b361ed75f, data reload: false
query5 4438 627 494 494
query6 370 227 209 209
query7 4216 464 270 270
query8 334 262 245 245
query9 8677 2897 2882 2882
query10 535 378 332 332
query11 15329 15228 14896 14896
query12 172 111 113 111
query13 1242 473 397 397
query14 5684 3018 2752 2752
query14_1 2636 2628 2657 2628
query15 203 196 175 175
query16 991 488 465 465
query17 1108 659 550 550
query18 2423 430 349 349
query19 212 206 184 184
query20 119 110 108 108
query21 212 135 116 116
query22 3930 4103 3914 3914
query23 15932 15635 15375 15375
query23_1 15556 15453 15332 15332
query24 7124 1505 1149 1149
query24_1 1141 1149 1147 1147
query25 519 427 377 377
query26 1248 267 149 149
query27 2765 431 273 273
query28 4572 2161 2158 2158
query29 762 505 407 407
query30 308 230 205 205
query31 783 628 576 576
query32 86 77 71 71
query33 546 342 297 297
query34 909 862 525 525
query35 719 769 674 674
query36 882 919 842 842
query37 135 96 84 84
query38 2715 2728 2626 2626
query39 776 741 744 741
query39_1 706 711 724 711
query40 217 136 115 115
query41 65 63 63 63
query42 101 102 108 102
query43 455 489 405 405
query44 1320 757 743 743
query45 185 181 171 171
query46 815 932 570 570
query47 1354 1462 1343 1343
query48 299 323 236 236
query49 605 439 341 341
query50 616 263 198 198
query51 3819 3791 3832 3791
query52 104 110 95 95
query53 284 318 271 271
query54 285 261 253 253
query55 86 83 77 77
query56 311 313 296 296
query57 1024 995 901 901
query58 269 249 263 249
query59 2043 2158 2112 2112
query60 349 329 312 312
query61 147 141 144 141
query62 410 345 305 305
query63 295 259 254 254
query64 4974 1224 1052 1052
query65 3721 3792 3799 3792
query66 1464 426 327 327
query67 15367 15484 15503 15484
query68 2401 1119 784 784
query69 443 373 331 331
query70 998 983 942 942
query71 333 317 295 295
query72 5461 3234 3336 3234
query73 587 710 308 308
query74 8751 8714 8614 8614
query75 2737 2780 2407 2407
query76 2273 1050 648 648
query77 374 372 328 328
query78 9756 9906 9133 9133
query79 1494 891 585 585
query80 1275 545 479 479
query81 539 262 240 240
query82 978 143 113 113
query83 322 248 242 242
query84 256 125 90 90
query85 876 468 416 416
query86 417 296 286 286
query87 2862 2858 2841 2841
query88 3516 2586 2579 2579
query89 392 350 330 330
query90 2004 175 158 158
query91 165 155 131 131
query92 78 74 69 69
query93 1071 872 542 542
query94 677 275 289 275
query95 590 397 328 328
query96 652 510 226 226
query97 2341 2381 2318 2318
query98 219 206 195 195
query99 586 567 548 548
Total cold run time: 246542 ms
Total hot run time: 173987 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3772796066
<details>
<summary>TPC-H: <b>Total hot run time: 31655 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03c8e3336f3e2d41ebe33618c694226b361ed75f, data reload: false
------ Round 1 ----------------------------------
q1 17619 4197 4027 4027
q2 2019 345 241 241
q3 10152 1299 687 687
q4 10216 854 315 315
q5 7511 2085 1826 1826
q6 189 166 134 134
q7 942 753 643 643
q8 9252 1365 1156 1156
q9 5238 4567 4629 4567
q10 6773 1764 1373 1373
q11 519 290 278 278
q12 721 713 581 581
q13 17820 3858 3052 3052
q14 307 295 272 272
q15 584 506 506 506
q16 693 683 627 627
q17 656 812 460 460
q18 7285 6320 6790 6320
q19 1310 1089 668 668
q20 416 408 262 262
q21 3165 2663 2681 2663
q22 1121 1125 997 997
Total cold run time: 104508 ms
Total hot run time: 31655 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4322 4415 4297 4297
q2 332 434 328 328
q3 2245 2835 2471 2471
q4 1382 1855 1366 1366
q5 4594 4308 4344 4308
q6 220 171 131 131
q7 2010 1912 1758 1758
q8 2510 2475 2389 2389
q9 7276 7356 7100 7100
q10 2415 2923 2232 2232
q11 591 468 446 446
q12 704 757 625 625
q13 3580 3825 3042 3042
q14 269 280 259 259
q15 539 491 478 478
q16 609 650 597 597
q17 1128 1247 1316 1247
q18 7154 7275 7249 7249
q19 810 785 808 785
q20 1863 1966 1776 1776
q21 4490 4228 4113 4113
q22 1087 1039 935 935
Total cold run time: 50130 ms
Total hot run time: 47932 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #60042:
URL: https://github.com/apache/doris/pull/60042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3772865009
<details>
<summary>ClickBench: <b>Total hot run time: 26.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03c8e3336f3e2d41ebe33618c694226b361ed75f, data reload: false
query1 0.05 0.04 0.04
query2 0.10 0.04 0.04
query3 0.26 0.09 0.09
query4 1.61 0.12 0.12
query5 0.28 0.27 0.25
query6 1.14 0.64 0.66
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.57 0.48 0.49
query10 0.55 0.54 0.56
query11 0.15 0.09 0.10
query12 0.14 0.11 0.10
query13 0.59 0.58 0.59
query14 0.94 0.95 0.93
query15 0.78 0.77 0.78
query16 0.41 0.42 0.38
query17 1.02 1.05 1.04
query18 0.22 0.21 0.21
query19 2.00 1.89 1.91
query20 0.02 0.02 0.02
query21 15.42 0.24 0.15
query22 5.20 0.05 0.05
query23 15.78 0.28 0.10
query24 1.72 0.53 0.27
query25 0.11 0.08 0.05
query26 0.15 0.13 0.13
query27 0.08 0.07 0.05
query28 3.34 1.06 0.88
query29 12.52 3.94 3.14
query30 0.28 0.14 0.11
query31 2.82 0.61 0.38
query32 3.24 0.56 0.45
query33 3.04 2.99 2.99
query34 16.00 5.07 4.44
query35 4.45 4.47 4.46
query36 0.65 0.50 0.49
query37 0.11 0.06 0.06
query38 0.08 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 96.28 s
Total hot run time: 26.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3773512655
# BE Regression && UT Coverage Report
Increment line coverage `84.21% (16/19)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60042_03c8e3336f3e2d41ebe33618c694226b361ed75f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60042_03c8e3336f3e2d41ebe33618c694226b361ed75f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.44% (25450/35622) |
| Line Coverage | 53.95% (266237/493497) |
| Region Coverage | 51.57% (220780/428100) |
| Branch Coverage | 53.00% (94831/178940) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60042:
URL: https://github.com/apache/doris/pull/60042#discussion_r2711267404
##########
be/src/vec/exec/format/column_type_convert.h:
##########
@@ -615,7 +615,7 @@ class DateTimeToNumericConverter : public ColumnTypeConverter {
}
size_t rows = from_col->size();
- auto& src_data = static_cast<const SrcColumnType*>(from_col.get())->get_data();
+ const auto& src_data = static_cast<const SrcColumnType*>(from_col.get())->get_data();
Review Comment:
The auto keyword is being changed to const auto&, which is good for avoiding unnecessary copies. However, this change appears unrelated to the PR's stated purpose of removing useless return type checks from unix_timestamp. Consider moving this change to a separate commit or clarifying its relationship to the main refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](function) Remove useless return type check of unix_timstamp [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60042:
URL: https://github.com/apache/doris/pull/60042#issuecomment-3769224704
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org