You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/28 03:30:36 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
panbingkun opened a new pull request, #41345:
URL: https://github.com/apache/spark/pull/41345
### What changes were proposed in this pull request?
The pr aims to use error classes in the compilation errors of `ResolveDefaultColumns`.
### Why are the changes needed?
The changes improve the error framework.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Update UT.
- Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41345:
URL: https://github.com/apache/spark/pull/41345#issuecomment-1566185697
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #41345:
URL: https://github.com/apache/spark/pull/41345#issuecomment-1569094328
Just saw this, thanks a lot for the improvement!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
URL: https://github.com/apache/spark/pull/41345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41345: [SPARK-43834][SQL] Use error classes in the compilation errors of `ResolveDefaultColumns`
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41345:
URL: https://github.com/apache/spark/pull/41345#issuecomment-1566135557
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org