You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "duongcongtoai (via GitHub)" <gi...@apache.org> on 2023/03/28 18:54:49 UTC
[GitHub] [arrow-datafusion] duongcongtoai opened a new pull request, #5768: add assert on hash children partition count
duongcongtoai opened a new pull request, #5768:
URL: https://github.com/apache/arrow-datafusion/pull/5768
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] duongcongtoai commented on pull request #5768: Add assert on hash children partition count
Posted by "duongcongtoai (via GitHub)" <gi...@apache.org>.
duongcongtoai commented on PR #5768:
URL: https://github.com/apache/arrow-datafusion/pull/5768#issuecomment-1497154408
Test is failing, i'll check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5768: Add assert on hash children partition count
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5768:
URL: https://github.com/apache/arrow-datafusion/pull/5768#issuecomment-1499476534
I took the liberty to push a fix for the clippy CI failure: https://github.com/apache/arrow-datafusion/actions/runs/4622652579/jobs/8194716556 to your branch in https://github.com/apache/arrow-datafusion/pull/5768/commits/a29658b1140d4917c78f4d397ac77da543deee37
I also merged up from main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5768: Add assert on hash children partition count
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5768:
URL: https://github.com/apache/arrow-datafusion/pull/5768#discussion_r1157553177
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -377,6 +370,13 @@ impl ExecutionPlan for HashJoinExec {
) -> Result<SendableRecordBatchStream> {
let on_left = self.on.iter().map(|on| on.0.clone()).collect::<Vec<_>>();
let on_right = self.on.iter().map(|on| on.1.clone()).collect::<Vec<_>>();
+ if self.mode == PartitionMode::Partitioned
+ && self.left.output_partitioning() != self.right.output_partitioning()
+ {
+ return Err(DataFusionError::Plan(format!(
Review Comment:
This is likely caused by some sort of code error, so an internal error may make more sense
```suggestion
return Err(DataFusionError::Internal(format!(
```
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -377,6 +370,13 @@ impl ExecutionPlan for HashJoinExec {
) -> Result<SendableRecordBatchStream> {
let on_left = self.on.iter().map(|on| on.0.clone()).collect::<Vec<_>>();
let on_right = self.on.iter().map(|on| on.1.clone()).collect::<Vec<_>>();
+ if self.mode == PartitionMode::Partitioned
+ && self.left.output_partitioning() != self.right.output_partitioning()
+ {
+ return Err(DataFusionError::Plan(format!(
Review Comment:
The same comment applies to the code below as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5768: Add assert on hash children partition count
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5768:
URL: https://github.com/apache/arrow-datafusion/pull/5768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org