You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/03/13 19:27:22 UTC
[GitHub] [beam] bvolpato opened a new pull request, #25827: Improve stage race condition by checking if staged before each try
bvolpato opened a new pull request, #25827:
URL: https://github.com/apache/beam/pull/25827
A race condition can be easily introduced and exhaust all `withMaxRetries(4)` with 2 job submissions / threads staging the same JAR at the same time, especially for large JARs:
> 2023-03-13 18:19:40 INFO TemplateTestBase:35 - 2023-03-13 18:19:40 WARN RetryHttpRequestInitializer:165 - Request failed with code 412, performed 0 retries due to IOExceptions, performed 0 retries due to unsuccessful status codes, HTTP framework says request can be retried, (caller responsible for retrying): https://storage.googleapis.com/upload/storage/v1/b/{bucket}/o?ifGenerationMatch=1678731567510887&name=2023-03-13-18-11_IT/staging/hbase-shaded-server-1.4.12-{hash}.jar&uploadType=resumable&upload_id={id}.
>
> 2023-03-13 18:19:40 INFO TemplateTestBase:35 - 2023-03-13 18:19:40 ERROR PackageUtil:191 - Upload failed, will NOT retry staging of package: /home/{user}/.m2/repository/org/apache/hbase/hbase-shaded-server/1.4.12/hbase-shaded-server-1.4.12.jar
>
> 2023-03-13 18:19:40 INFO TemplateTestBase:35 - java.io.IOException: Upload failed for 'gs://{bucket}/2023-03-13-18-11_IT/staging/hbase-shaded-server-1.4.12-{hash}.jar'
Even in scenarios in which a concurrent submission goes through, the artifacts are re-uploaded, making the cache useless under racing.
This change will check if the file was already staged before each try, instead of before entering the retry loop.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] ~Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.~
- [ ] ~Update `CHANGES.md` with noteworthy changes.~
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #25827: Improve stage race condition by checking if staged before each try
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #25827:
URL: https://github.com/apache/beam/pull/25827#issuecomment-1468344558
My bad, done -- feel free to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #25827: Improve stage race condition by checking if staged before each try
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #25827:
URL: https://github.com/apache/beam/pull/25827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #25827: Improve stage race condition by checking if staged before each try
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #25827:
URL: https://github.com/apache/beam/pull/25827#issuecomment-1468174482
Thanks @Abacn. Fixed it now. I had tested the functionality and didn't notice that test class.
Change was just around Mockito's `verify` as it now calls `getObjects` `n` times for `n` tries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25827: Improve stage race condition by checking if staged before each try
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25827:
URL: https://github.com/apache/beam/pull/25827#issuecomment-1467269399
Looks like the failed unit tests are relevant?
```
org.apache.beam.runners.dataflow.util.PackageUtilTest.testPackageUploadEventuallySucceeds
org.apache.beam.runners.dataflow.util.PackageUtilTest.testPackageUploadFailsWhenIOExceptionThrown
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org