[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1475: DISPATCH-2305: prevent policy defaults overriding configuration

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781266132



##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -2358,21 +2358,18 @@
                 "maxFrameSize": {
                     "type": "integer",
                     "description": "The largest frame, in bytes, that may be sent on this connection. Non-zero policy values overwrite values specified for a listener object (AMQP Open, max-frame-size).",
-                    "default": 16384,

Review comment:
       Bear with me here but when I look at this from a layman's perspective, I like seeing the defaults in the json schema and this PR seems to remove the defaults from the schema. Is there a way that these defaults can be still there and if the policy does not overide these values, the defaults can be used? Is that too much work from the policy side ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org