You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/08 10:03:00 UTC
[jira] [Commented] (OPENNLP-1159) avoid letting users specify
AggregatedFeatureGeneratorFactory in XML config
[ https://issues.apache.org/jira/browse/OPENNLP-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316001#comment-16316001 ]
ASF GitHub Bot commented on OPENNLP-1159:
-----------------------------------------
kottmann commented on a change in pull request #300: OPENNLP-1159: avoid letting users specify AggregatedFeatureGeneratorF…
URL: https://github.com/apache/opennlp/pull/300#discussion_r160105968
##########
File path: opennlp-tools/src/main/resources/opennlp/tools/namefind/ner-default-features.xml
##########
@@ -19,9 +19,7 @@
<!-- Default name finder feature generator configuration -->
<featureGenerators name="nameFinder">
- <generator class="opennlp.tools.util.featuregen.AggregatedFeatureGeneratorFactory">
<generator class="opennlp.tools.util.featuregen.CachedFeatureGeneratorFactory">
Review comment:
That looks much nicer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> avoid letting users specify AggregatedFeatureGeneratorFactory in XML config
> ---------------------------------------------------------------------------
>
> Key: OPENNLP-1159
> URL: https://issues.apache.org/jira/browse/OPENNLP-1159
> Project: OpenNLP
> Issue Type: Improvement
> Components: Formats, Name Finder
> Affects Versions: 1.8.3
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
>
> When I'm working on OPENNLP-1154, I think we should do it for better use.
> I'd like to implement this as an independent ticket from OPENNLP-1154 to make patch easy to read.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)