[GitHub] [superset] doctorseus commented on pull request #24835: feat: allow database configuration via env variable

["doctorseus (via GitHub)" <gi...@apache.org>]

doctorseus commented on PR #24835:
URL: https://github.com/apache/superset/pull/24835#issuecomment-1658929686

   > @doctorseus have you seen the documentation outlined [here](https://github.com/apache/superset/blob/master/docker/README.md#local-overrides) regarding local Docker overrides? Wouldn't this be sufficient for your needs?
   
   This would also only allow you to change the configuration if you plan to rebuild the original image for each DB you want to connect to. 
   
   But if you look at https://hub.docker.com/r/apache/superset on how to use this image then the documentation only tells you to set `SUPERSET_SECRET_KEY` before running. There is currently no option to use this image directly with a permanent DB other then the embedded sqlite file. Adding this ENV variable would allow users of that docker image to do just that. 
   
   Admittedly this might be more or less useful depending on what sqlalchemy drivers you have pre-installed in the image but in our case we use this behavior already. We run multiple environments (dev, staging, production) using the same image (a custom superset build) but connect them to different databases depending on where they are running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org