You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/30 14:46:14 UTC

[GitHub] [calcite] libenchao commented on a diff in pull request #2889: [CALCITE-5253] Natural join fields validation partially broken after CALCITE-5171

libenchao commented on code in PR #2889:
URL: https://github.com/apache/calcite/pull/2889#discussion_r984672791


##########
core/src/main/java/org/apache/calcite/rel/type/RelCrossType.java:
##########
@@ -58,6 +58,15 @@ public RelCrossType(
     return false;
   }
 
+  /**
+   * Returns the contained types.
+   *
+   * @return Data types.
+   */
+  public ImmutableList<RelDataType> getTypes() {

Review Comment:
   Is `ImmutableList<RelDataType>` too specific? How about `List<RelDataType>`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org