You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/12 07:20:56 UTC
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17059
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
KUDU-2612: non-zero queue size for txn-commit pool
I found my new tests for the automatic txn participant registration
often hit the following CHECK():
F0212 06:49:33.448449 611 txn_status_manager.cc:371] Check failed: _s.ok() Bad status: Service unavailable: Thread pool is at capacity (10/10 tasks running, 2/0 tasks queued)
As I can see, the code in CommitTasks::ScheduleAbortTxnWrite() doesn't
handle the condition of running out of the "txn-commit" pool's queue.
That means the pool is supposed to have an unlimited queue size, like
other pools which exhibit similar behaviour: e.g., the pool for removing
tablets, the pool for opening tablets, etc. Indeed, since the number of
concurrently opened multi-row transactions isn't limited,
TxnStatusManager should be able handle the case when many transactions
are being finalized simultaneously.
This patch removes the queue size limit for the "txn-commit" pool
(i.e. effectively setting it to INT_MAX), mirroring the behavior of
"tablet-open" and "tablet-delete" pools.
Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
---
M src/kudu/tserver/ts_tablet_manager.cc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/17059/1
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17059 )
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
Patch Set 3:
> Thanks for finding and fixing this!
Thank you for fast review :)
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Feb 2021 15:32:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17059 )
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
Patch Set 2: Code-Review+2
Thanks for finding and fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Feb 2021 08:17:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17059 )
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
KUDU-2612: non-zero queue size for txn-commit pool
I found my new tests for the automatic txn participant registration
often hit the following CHECK():
F0212 06:49:33.448449 611 txn_status_manager.cc:371] Check failed: _s.ok() Bad status: Service unavailable: Thread pool is at capacity (10/10 tasks running, 2/0 tasks queued)
As I can see, the code in
CommitTasks::Schedule{AbortTxn,FinalizeCommit}Write() doesn't handle
the condition of running out of the "txn-commit" pool's queue. That
means the pool is supposed to have an unlimited queue size, like other
pools which exhibit similar behaviour: e.g., the pool for removing
tablets, the pool for opening tablets, etc. Indeed, since the number of
concurrently opened multi-row transactions isn't limited,
TxnStatusManager should be able handle the case when many transactions
are being aborted and committed simultaneously.
This patch removes the queue size limit for the "txn-commit" pool
(effectively setting it to INT_MAX), mirroring the behavior of the
"tablet-open" and "tablet-delete" pools.
Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Reviewed-on: http://gerrit.cloudera.org:8080/17059
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/ts_tablet_manager.cc
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17059
to look at the new patch set (#2).
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
KUDU-2612: non-zero queue size for txn-commit pool
I found my new tests for the automatic txn participant registration
often hit the following CHECK():
F0212 06:49:33.448449 611 txn_status_manager.cc:371] Check failed: _s.ok() Bad status: Service unavailable: Thread pool is at capacity (10/10 tasks running, 2/0 tasks queued)
As I can see, the code in
CommitTasks::Schedule{AbortTxn,FinalizeCommit}Write() doesn't handle
the condition of running out of the "txn-commit" pool's queue. That
means the pool is supposed to have an unlimited queue size, like other
pools which exhibit similar behaviour: e.g., the pool for removing
tablets, the pool for opening tablets, etc. Indeed, since the number of
concurrently opened multi-row transactions isn't limited,
TxnStatusManager should be able handle the case when many transactions
are being aborted and committed simultaneously.
This patch removes the queue size limit for the "txn-commit" pool
(effectively setting it to INT_MAX), mirroring the behavior of the
"tablet-open" and "tablet-delete" pools.
Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
---
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/ts_tablet_manager.cc
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/17059/2
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17059 )
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Feb 2021 15:32:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: non-zero queue size for txn-commit pool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2612: non-zero queue size for txn-commit pool
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idb3de2fd41936862eec8f2616096db16ff86c070
Gerrit-Change-Number: 17059
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)