You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/10 07:43:36 UTC
[GitHub] [airflow] turbaszek opened a new pull request #9203: Make generated job_id more informative in BQ insert_job
turbaszek opened a new pull request #9203:
URL: https://github.com/apache/airflow/pull/9203
As per comment in #8903
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9203: Make generated job_id more informative in BQ insert_job
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9203:
URL: https://github.com/apache/airflow/pull/9203#discussion_r438177004
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1636,6 +1636,7 @@ def execute(self, context: Any):
project_id=self.project_id,
location=self.location,
job_id=self.job_id,
+ _task_id=self.task_id
Review comment:
This is only optional and is used only when there's no job_id passed by the user. This will help users with troubleshooting problems with their DAGs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9203: Make generated job_id more informative in BQ insert_job
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9203:
URL: https://github.com/apache/airflow/pull/9203#discussion_r438147912
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1636,6 +1636,7 @@ def execute(self, context: Any):
project_id=self.project_id,
location=self.location,
job_id=self.job_id,
+ _task_id=self.task_id
Review comment:
Why are you passing task_id to the hook? I think it would be better if hook is not aware of the task. You can generate a job ID and pass it as a parameter in the operator. Did I miss something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9203: Make generated job_id more informative in BQ insert_job
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9203:
URL: https://github.com/apache/airflow/pull/9203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9203: Make generated job_id more informative in BQ insert_job
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9203:
URL: https://github.com/apache/airflow/pull/9203#issuecomment-642077965
@mik-laj please take another look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org