You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "jikechao (via GitHub)" <gi...@apache.org> on 2023/06/13 08:06:48 UTC

[GitHub] [tvm] jikechao commented on a diff in pull request #15053: [Bugfix][Relay][Keras] Fix the wrong implementation logic about cropping2D

jikechao commented on code in PR #15053:
URL: https://github.com/apache/tvm/pull/15053#discussion_r1227706944


##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -443,6 +443,11 @@ def test_forward_crop(self, keras_mod):
         keras_model = keras_mod.models.Model(data, x)
         verify_keras_frontend(keras_model)
 
+        x = keras_mod.layers.Cropping2D(cropping=(2, 1))(data)
+        x = keras_mod.layers.Cropping2D(cropping=(1, 2))(x)
+        keras_model = keras_mod.models.Model(data, x)
+        verify_keras_frontend(keras_model, layout="NHWC")

Review Comment:
   Thanks for your reminder, related test cases have been added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org