[jira] [Commented] (HDFS-5903) FSVolumeList#initializeReplicaMaps(..) not doing anything, it can be removed

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894476#comment-13894476 ] 

Hadoop QA commented on HDFS-5903:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12627610/HDFS-5903.patch
  against trunk revision .

    {color:red}-1 patch{color}.  Trunk compilation may be broken.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6067//console

This message is automatically generated.

> FSVolumeList#initializeReplicaMaps(..) not doing anything, it can be removed
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-5903
>                 URL: https://issues.apache.org/jira/browse/HDFS-5903
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-5903.patch
>
>
> {code}  void initializeReplicaMaps(ReplicaMap globalReplicaMap) throws IOException {
>     for (FsVolumeImpl v : volumes) {
>       v.getVolumeMap(globalReplicaMap);
>     }
>   }{code}
> This method has been called at the time of initialization even before the blockpools are added. So its useless to call this method.
> Anyway replica map will be updated for each of the blockpool during {{addBlockPool(..)}} by calling {{FSVolumesList#getAllVolumesMap(..)}}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)