You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by packysauce <gi...@git.apache.org> on 2017/05/30 23:35:31 UTC
[GitHub] zookeeper pull request #267: ZOOKEEPER-2797 Defend against bad TTLs from mis...
GitHub user packysauce opened a pull request:
https://github.com/apache/zookeeper/pull/267
ZOOKEEPER-2797 Defend against bad TTLs from misbehaving clients
Validate the TTL before it makes it to the commit processor to prevent blowing up ZK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/packysauce/zookeeper protect_from_bad_ttl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit 00541acbbffcd6c3d4267078f1644e554e1200f8
Author: Patrick White <pa...@patrickwhite.org>
Date: 2017-05-30T20:22:41Z
ZOOKEEPER-2797 Defend against bad TTLs from misbehaving clients
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #267: ZOOKEEPER-2797 Defend against bad TTLs from mis...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/267#discussion_r119269582
--- Diff: src/java/test/org/apache/zookeeper/server/CreateTTLTest.java ---
@@ -69,6 +75,23 @@ public void testCreate()
}
@Test
+ public void testBadTTLs()
+ throws IOException, KeeperException, InterruptedException {
+ Stat stat = new Stat();
--- End diff --
nit: is this needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #267: ZOOKEEPER-2797 Defend against bad TTLs from misbehavin...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/267
lgtm, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #267: ZOOKEEPER-2797 Defend against bad TTLs from mis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #267: ZOOKEEPER-2797 Defend against bad TTLs from misbehavin...
Posted by packysauce <gi...@git.apache.org>.
Github user packysauce commented on the issue:
https://github.com/apache/zookeeper/pull/267
The failed test in jenkins runs fine for me locally, and the logs indicated succeeded (if I'm interpreting that correctly)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #267: ZOOKEEPER-2797 Defend against bad TTLs from mis...
Posted by packysauce <gi...@git.apache.org>.
Github user packysauce commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/267#discussion_r119270375
--- Diff: src/java/test/org/apache/zookeeper/server/CreateTTLTest.java ---
@@ -69,6 +75,23 @@ public void testCreate()
}
@Test
+ public void testBadTTLs()
+ throws IOException, KeeperException, InterruptedException {
+ Stat stat = new Stat();
--- End diff --
Ah! the first version of this went through the zk client-ish interface, so probably not needed anymore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---