You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2016/01/26 07:56:04 UTC
[5/5] git commit: updated refs/heads/4.7 to 1e4bc9a
Merge pull request #1358 from ekholabs/fix/4.7-acl-delete-CLOUDSTACK-9245
CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains itemsThis PR fixes the issue when trying to delete ACL lists which contain item.
It seemed it was not thought of when the ACS project started, when most user were relying on the UI to execute those tasks. Nowadays, with automation all over the place and ACL lists containing hundreds of items, it's very hard to have to delete them 1 by 1 either via the UI. Writing scripts to do so might be a solution, but it would be much simpler to just delete non-attached ACLs with all its items in one go.
Also, destroying a VPC that contains ACL lists was "succeeding", but after that the ACL list/items were messing up:
```
list networkacls aclid=920d74b6-4d15-454f-b3a6-61e7a6ffd1a4
Error 431: Unable to find VPC associated with acl
{
"cserrorcode": 4350,
"errorcode": 431,
"errortext": "Unable to find VPC associated with acl",
"uuidList": []
}
```
So, it also cleans up ACLs when destroying VPCs
* pr/1358:
CLOUDSTACK-9245 - Deletes ACL items when destroying the VPC or deleting the ACL itself
CLOUDSTACK-9245 - Formatting NetworkACLServiceImpl class
CLOUDSTACK-9245 - Formatting VpcManagerImpl class
CLOUDSTACK-9245 - Formatting NetworkACLManagerImpl class
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1e4bc9ae
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1e4bc9ae
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1e4bc9ae
Branch: refs/heads/4.7
Commit: 1e4bc9ae9d8c5392617b68258af4a7edb75e8ce3
Parents: 7ad0d47 3ec37a0
Author: Remi Bergsma <gi...@remi.nl>
Authored: Tue Jan 26 07:55:40 2016 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Tue Jan 26 07:55:41 2016 +0100
----------------------------------------------------------------------
.../cloud/network/vpc/NetworkACLService.java | 5 +-
.../network/vpc/NetworkACLManagerImpl.java | 135 +++----
.../network/vpc/NetworkACLServiceImpl.java | 251 ++++++------
.../com/cloud/network/vpc/VpcManagerImpl.java | 397 ++++++++++---------
.../com/cloud/vpc/NetworkACLManagerTest.java | 72 ++--
5 files changed, 444 insertions(+), 416 deletions(-)
----------------------------------------------------------------------