You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/03/13 21:36:03 UTC

Re: [PR] chore: rewrite code snippets that are referenced to Stack Overflow [texera]

Ma77Ball commented on code in PR #4283:
URL: https://github.com/apache/texera/pull/4283#discussion_r2933836477


##########
common/workflow-operator/src/main/scala/com/kjetland/jackson/jsonSchema/JsonSchemaGenerator.scala:
##########
@@ -1483,17 +1483,33 @@ class JsonSchemaGenerator(
   }
 
   def generateTitleFromPropertyName(propertyName: String): String = {

Review Comment:
   There seems to be no protection from empty strings. I recommend adding an assertion or an if-statement check to prevent invalid input. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org