You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 13:13:46 UTC
[GitHub] [flink] ayushtkn opened a new pull request #10998: [FLINK-15740]
Remove Deadline#timeLeft()
ayushtkn opened a new pull request #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] ayushtkn commented on issue #10998: [FLINK-15740] Remove
Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-582737574
There is a discussion at the Jira, you can give a check. @TisonKun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10998: [FLINK-15740] Remove
Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-584092918
Closing this PR for now.
There is no consensus on the Jira issue if the method should actually be removed, or if there should be a replacement for that method. The code change is very simple, the tricky thing is deciding what is the best approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #10998: [FLINK-15740] Remove
Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-582731048
1. I think it is about `#timeLeftIfAny`
2. What is the motivation of the change? `timeLeftIfAny` throws an exception when deadline is overdue. It is a different manner than `#timeLeft`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10998: [FLINK-15740] Remove
Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-581417019
<!--
Meta data
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
-->
## CI report:
* a918a77e46b75b73e1c40f27f339e9ec5a7a8abc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen closed pull request #10998: [FLINK-15740]
Remove Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
StephanEwen closed pull request #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10998: [FLINK-15740] Remove
Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-581408327
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a918a77e46b75b73e1c40f27f339e9ec5a7a8abc (Mon Feb 03 13:15:44 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15740).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10998: [FLINK-15740]
Remove Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-581417019
<!--
Meta data
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147202505 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
-->
## CI report:
* a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147202505) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10998: [FLINK-15740]
Remove Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-581417019
<!--
Meta data
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147202505 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
-->
## CI report:
* a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147202505) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10998: [FLINK-15740]
Remove Deadline#timeLeft()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10998: [FLINK-15740] Remove Deadline#timeLeft()
URL: https://github.com/apache/flink/pull/10998#issuecomment-581417019
<!--
Meta data
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147202505 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
Hash:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780 TriggerType:PUSH TriggerID:a918a77e46b75b73e1c40f27f339e9ec5a7a8abc
-->
## CI report:
* a918a77e46b75b73e1c40f27f339e9ec5a7a8abc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147202505) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services