You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/09 13:38:12 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #8876: Add integration tests for package management service
eolivelli commented on a change in pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#discussion_r539311538
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
Review comment:
what about naming this method` getPackagesReplicas() `?
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
- return Integer.parseInt(getProperty("numReplicas"));
+ return Integer.parseInt(getProperty("packagesReplicas"));
}
String getZkServers() {
- return getProperty("zkServers");
+ return getProperty("zookeeperServers");
Review comment:
what about naming this method getZookeeperServers() `?
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
- return Integer.parseInt(getProperty("numReplicas"));
+ return Integer.parseInt(getProperty("packagesReplicas"));
}
String getZkServers() {
- return getProperty("zkServers");
+ return getProperty("zookeeperServers");
}
String getLedgersRootPath() {
- return getProperty("ledgerRootPath");
+ return getProperty("packagesManagementLedgerRootPath");
Review comment:
what about naming this method `getPackagesManagementLedgerRootPath()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org