[GitHub] stevedlawrence commented on a change in pull request #55: Fixes the issue of separated empty optional elements, (ie. 1:2::4:5).

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #55: Fixes the issue of separated empty optional elements, (ie. 1:2::4:5).
URL: https://github.com/apache/incubator-daffodil/pull/55#discussion_r175468454
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/LocalElementGrammarMixin.scala
 ##########
 @@ -112,8 +112,11 @@ trait LocalElementGrammarMixin extends GrammarMixin { self: ElementBase =>
     // We don't know if this repeating thing is in trailing position, or in the middle
     // of a sequence. There is also ambiguity if the enclosing sequence and this sequence
     // have the same separator.
-    //      ~
-    //      RepAtMostTotalN(self, maxOccurs, separatedEmpty) // absorb extra separators, if found.
+    ~
+    (if (couldBeLastElementInModelGroup)
+      RepAtMostTotalN(self, maxOccurs, separatedEmpty) // absorb extra separators, if found.
+    else
+      EmptyGram)
     )
 
 Review comment:
   Does this the issue mentioned in the comment? Seems like it does, and if so the comment should be removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services