You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/01 15:21:49 UTC

[GitHub] [kafka] dengziming opened a new pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator and use it to read/write ReassignPartitionsCommand json file

dengziming opened a new pull request #9809:
URL: https://github.com/apache/kafka/pull/9809


   *More detailed description of your change*
   1. Add a field `jsonFieldNameStrategy` in `MessageSpec` when represent the naming strategy of JsonConverter
   2. `jsonFieldNameStrategy` can be "camel" or "camel", "camel" is default value
   3. Use `PartitionReassignmentArgsJsonConverter` to read and write ReassignPartitionsCommand json file
   
   *Summary of testing strategy (including rationale)*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming closed pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator

Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9809:
URL: https://github.com/apache/kafka/pull/9809


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9809:
URL: https://github.com/apache/kafka/pull/9809#issuecomment-861545466


   Hmm... Isn't it better just to standardize on one thing? Camel case seems fine for the message format JSON files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9809:
URL: https://github.com/apache/kafka/pull/9809#issuecomment-861995774


   see comment https://issues.apache.org/jira/browse/KAFKA-10898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9809:
URL: https://github.com/apache/kafka/pull/9809#issuecomment-757410251


   @cmccabe @mumrah , Hi, I want to hear from your opinion, thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org