You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/13 03:42:21 UTC
[GitHub] [superset] u-aiaa opened a new issue #15649: The chart in the report screenshot is sent before the animation is finished.
u-aiaa opened a new issue #15649:
URL: https://github.com/apache/superset/issues/15649
The chart in the report screenshot is sent before the animation is finished.
### Expected results
Take a screenshot of the chart with the chart animation finished and send the report.
### Actual results
Before the chart animation is finished, a screenshot is taken and a report is sent.
#### Screenshots
Image sent as a report
#### How to reproduce the bug
### Environment
- superset version: Superset 1.2.0
- python version: Python 3.7.9
- node.js version:
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- There was no stack trace.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Pull request submitted. https://github.com/apache/superset/pull/15610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15649: The chart in the report screenshot is sent before the animation is finished.
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15649:
URL: https://github.com/apache/superset/issues/15649#issuecomment-880297204
makes sense! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15649: The chart in the report screenshot is sent before the animation is finished.
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15649:
URL: https://github.com/apache/superset/issues/15649#issuecomment-879245170
@u-aiaa can you clarify what "animation" means in a video or gif? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] u-aiaa commented on issue #15649: The chart in the report screenshot is sent before the animation is finished.
Posted by GitBox <gi...@apache.org>.
u-aiaa commented on issue #15649:
URL: https://github.com/apache/superset/issues/15649#issuecomment-881113936
#15610 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] u-aiaa commented on issue #15649: The chart in the report screenshot is sent before the animation is finished.
Posted by GitBox <gi...@apache.org>.
u-aiaa commented on issue #15649:
URL: https://github.com/apache/superset/issues/15649#issuecomment-879543304
@junlincc
This is a video of the chart when viewed in a browser.
When submitting a report, I wondered if a screenshot would be taken before this animation was finished. Therefore, I added a wait time to the pull request.
Instead of a wait time, should it not animate when sending a report?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] u-aiaa closed issue #15649: The chart in the report screenshot is sent before the animation is finished.
Posted by GitBox <gi...@apache.org>.
u-aiaa closed issue #15649:
URL: https://github.com/apache/superset/issues/15649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org