[GitHub] [hadoop] vnhive edited a comment on pull request #3966: [WIP] HADOOP-15980 : Enable TLS in RPC client/server

[GitBox <gi...@apache.org>]

vnhive edited a comment on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1055331375


   @jojochuang I have raised a new pull request with the following changes
   
   Adding support for reading ssl configuration from ssl-server.xml and
   ssl-client.xml. This unifies this patch with the rest of the hadoop SSL
   ecosystem.
   
   The patch has added a file SSLHandlerProvider that reads the ssl
   configuration files and creates the netty SslHandler object. This can be
   added to a Netty pipeline to encrypt the communication through the
   pipeline.
   
   The patch also adds a test case for the SSLHandlerProvider.
   
   In addition to this the patch modifies TestNettyRPC to read the SSL
   configuration from ssl-server.xml and ssl-client.xml.
   
   This is an intermediate patch that shows the changes made to read from
   the SSL certificates configured rather than use the inbuilt SSL certificates.
   
   The problem of test duplication remains and I am working to fix this. But since
   I had done a bunch of changes I thought I could submit an intermediate patch
   before a final one with the huge number of unit test changes.
   
   Thank you once again for the review comments in the previous patch. I will
   fix all the concerns you raised there in the next submission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org