You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangjiaochun <gi...@git.apache.org> on 2018/12/05 08:18:55 UTC
[GitHub] spark pull request #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Excepti...
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23226
[MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Exception test
## What changes were proposed in this pull request?
Add MAXIMUM_PAGE_SIZE_BYTES Exception test
## How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangjiaochun/spark BytesToBytesMapSuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23226
----
commit dd3b0e5fe45cd0d9f1bf689a6b4cd3cec41867a1
Author: 10087686 <wa...@...>
Date: 2018-12-05T08:10:38Z
add MAXIMUM_PAGE_SIZE_BYTES Exception test
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23226
**[Test build #4457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4457/testReport)** for PR 23226 at commit [`3a0fb2a`](https://github.com/apache/spark/commit/3a0fb2a5aed80e3f1d5154067af321a55e2db2fc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23226
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23226
**[Test build #4457 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4457/testReport)** for PR 23226 at commit [`3a0fb2a`](https://github.com/apache/spark/commit/3a0fb2a5aed80e3f1d5154067af321a55e2db2fc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Exception test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23226
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23226
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES e...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23226#discussion_r239662927
--- Diff: core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java ---
@@ -622,6 +622,17 @@ public void initialCapacityBoundsChecking() {
} catch (IllegalArgumentException e) {
// expected exception
}
+
+ try {
+ new BytesToBytesMap(
+ taskMemoryManager,
+ 1,
+ TaskMemoryManager.MAXIMUM_PAGE_SIZE_BYTES+1);
--- End diff --
`E_BYTES+1` -> `E_BYTES + 1`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Exception test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23226
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Excepti...
Posted by wangjiaochun <gi...@git.apache.org>.
Github user wangjiaochun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23226#discussion_r239066440
--- Diff: core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java ---
@@ -622,6 +622,17 @@ public void initialCapacityBoundsChecking() {
} catch (IllegalArgumentException e) {
// expected exception
}
+
+ try {
+ new BytesToBytesMap(
+ taskMemoryManager,
--- End diff --
ok,I will correct this indentation and propose JIRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23226
**[Test build #4462 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4462/testReport)** for PR 23226 at commit [`486f2b5`](https://github.com/apache/spark/commit/486f2b5c8b51f0f12782d9c9d1907c96a9298c89).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Exception test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23226
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23226: [MINOR][TEST] Add MAXIMUM_PAGE_SIZE_BYTES Excepti...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23226#discussion_r238977650
--- Diff: core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java ---
@@ -622,6 +622,17 @@ public void initialCapacityBoundsChecking() {
} catch (IllegalArgumentException e) {
// expected exception
}
+
+ try {
+ new BytesToBytesMap(
+ taskMemoryManager,
--- End diff --
Let's keep the indentation consistent
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23226
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23226: [SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exceptio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23226
**[Test build #4462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4462/testReport)** for PR 23226 at commit [`486f2b5`](https://github.com/apache/spark/commit/486f2b5c8b51f0f12782d9c9d1907c96a9298c89).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org