You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/03 09:30:15 UTC

[GitHub] [spark] dongjoon-hyun commented on issue #26010: [SPARK-29342][SQL] Make casting of string values to intervals case insensitive

dongjoon-hyun commented on issue #26010: [SPARK-29342][SQL] Make casting of string values to intervals case insensitive
URL: https://github.com/apache/spark/pull/26010#issuecomment-537866672
 
 
   If we can make it sure that the negative test cases are covered (or not needed), this PR looks promising. Do you expect performance improvement, too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org