You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/10/14 23:35:43 UTC
Review Request 26707: Admin View: Users page empty after delete view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26707/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-7776
https://issues.apache.org/jira/browse/AMBARI-7776
Repository: ambari
Description
-------
STR:
1) create user without permissions
2) create view instance
3)add user to view.use permission
4) delete view
5) navigate to users page
ER:
all users present
AR:
empty table
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java 87cb3ba
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrincipalEntity.java 4b826df
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1e28e62
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/PrincipalEntityTest.java e1e90fe
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 00da1bb
Diff: https://reviews.apache.org/r/26707/diff/
Testing
-------
Manual testing.
New unit tests added. All exiting tests pass ...
Results :
Tests run: 2171, Failures: 0, Errors: 0, Skipped: 17
…
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:22.093s
[INFO] Finished at: Tue Oct 14 17:22:24 EDT 2014
[INFO] Final Memory: 46M/378M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 26707: Admin View: Users page empty after delete
view
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26707/#review56788
-----------------------------------------------------------
Ship it!
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/PrincipalEntityTest.java
<https://reviews.apache.org/r/26707/#comment97199>
Nit: it may be helpful for one more assertion: that if you do a refresh() (or otherwise find(..)) from the DAO that the entities are indeed removed. The code as implemented appears to do both an in-memory and a db remove.
- Nate Cole
On Oct. 15, 2014, 3:19 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26707/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 3:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-7776
> https://issues.apache.org/jira/browse/AMBARI-7776
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1) create user without permissions
> 2) create view instance
> 3)add user to view.use permission
> 4) delete view
> 5) navigate to users page
> ER:
> all users present
> AR:
> empty table
>
> ----
>
> Also includes fix for User privileges not showing up because @Path("{userName}/privileges") was missing from UserService.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java 87cb3ba
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrincipalEntity.java 4b826df
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1e28e62
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/PrincipalEntityTest.java e1e90fe
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 00da1bb
>
> Diff: https://reviews.apache.org/r/26707/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> New unit tests added. All exiting tests pass ...
>
> Results :
>
> Tests run: 2171, Failures: 0, Errors: 0, Skipped: 17
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:22.093s
> [INFO] Finished at: Tue Oct 14 17:22:24 EDT 2014
> [INFO] Final Memory: 46M/378M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 26707: Admin View: Users page empty after delete
view
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26707/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 7:19 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Updated description.
Bugs: AMBARI-7776
https://issues.apache.org/jira/browse/AMBARI-7776
Repository: ambari
Description (updated)
-------
STR:
1) create user without permissions
2) create view instance
3)add user to view.use permission
4) delete view
5) navigate to users page
ER:
all users present
AR:
empty table
----
Also includes fix for User privileges not showing up because @Path("{userName}/privileges") was missing from UserService.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java 87cb3ba
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrincipalEntity.java 4b826df
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1e28e62
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/PrincipalEntityTest.java e1e90fe
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 00da1bb
Diff: https://reviews.apache.org/r/26707/diff/
Testing
-------
Manual testing.
New unit tests added. All exiting tests pass ...
Results :
Tests run: 2171, Failures: 0, Errors: 0, Skipped: 17
…
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:22.093s
[INFO] Finished at: Tue Oct 14 17:22:24 EDT 2014
[INFO] Final Memory: 46M/378M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower