You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/21 09:02:28 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7009: Ova checksums
DaanHoogland opened a new pull request, #7009:
URL: https://github.com/apache/cloudstack/pull/7009
### Description
This PR moves checksums from the test to test_data
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1054543457
##########
test/integration/smoke/test_templates.py:
##########
@@ -61,47 +61,27 @@ def setUp(self):
self.domain = get_domain(self.apiclient)
self.zone = get_zone(self.apiclient, self.testClient.getZoneForTests())
+ self.test_template = registerTemplate.registerTemplateCmd()
+ self.test_template.zoneid = self.zone.id
+
if "kvm" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "6952e58f39b470bd166ace11ffd20bf479bed936"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2"
- self.test_template.format = "QCOW2"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "88c60fd500ce7ced985cf845df0db9da"
- self.sha256 = "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
+ hyperindex = "kvm"
if "vmware" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "8b82224fd3c6429b6914f32d8339e650770c7526"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova"
- self.test_template.format = "OVA"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "b4e8bff3882b23175974e692533b4381"
- self.sha256 = "e1dffca3c3ab545a753cb42d838a341624cf25841d1bcf3d1e45556c9fce7cf3"
+ hyperindex = "vmware"
if "xen" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "80af2c18f96e94273188808c3d56e561a1cda717"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2"
- self.test_template.format = "VHD"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "1662bbf224e41bb62b1dee043d785731"
- self.sha256 = "80fba5a7a83842ec4e5f67cc6755d61d4fca46ae170d59b0c6ed47ebf7162722"
+ hyperindex = "xen"
Review Comment:
agreed,
btw I also saw some other places this is used, will have to check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1414329750
<b>Trillian test result (tid-6084)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43234 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6084-kvm-centos7.zip
Smoke tests completed. 101 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.03 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.03 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
test_01_add_primary_storage_disabled_host | `Error` | 0.62 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 113.81 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 78.08 | test_nonstrict_affinity_group.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 33.97 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 59.43 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 40.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 35.96 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 124.16 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 158.20 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 272.11 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 146.79 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.83 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.80 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1619604862
@DaanHoogland [SF] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1620797794
<b>[SF] Trillian test result (tid-6964)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6964-vmware-70u3.zip
Smoke tests completed. 107 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.26 | test_primary_storage.py
test_03_migration_options_storage_tags | `Error` | 0.02 | test_primary_storage.py
test_05_update_cmd | `Error` | 3.79 | test_disk_provisioning_types.py
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.04 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.04 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.04 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.04 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.05 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.04 | test_templates.py
test_01_deploy_vm_on_specific_host | `Error` | 0.09 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.14 | test_vm_deployment_planner.py
test_03_live_migrate_VM_with_two_data_disks | `Error` | 58.91 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 0.06 | test_vm_life_cycle.py
test_05_vmschedule_test_e2e | `Failure` | 230.96 | test_vm_schedule.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1436592087
<b>Trillian Build Failed (tid-6201)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361202389
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7009)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL)
[![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=coverage&view=list) No Coverage information
[![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361176006
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1617903763
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1619700892
@blueorangutan test rocky8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1623137340
<b>[SF] Trillian Build Failed (tid-6999)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361125511
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7009)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL)
[![28.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '28.6%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=new_coverage&view=list) [28.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=new_coverage&view=list)
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1362199522
<b>Trillian test result (tid-5608)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38523 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5608-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.20 | test_diagnostics.py
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.04 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.03 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.03 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
test_04_extract_template | `Failure` | 128.33 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1362218886
<b>Trillian test result (tid-5609)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40684 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5609-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.03 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.02 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1058955083
##########
tools/marvin/marvin/config/test_data.py:
##########
@@ -1003,7 +1006,10 @@
"url": "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2",
"requireshvm": "True",
"ispublic": "True",
- "isextractable": "True"
+ "isextractable": "True",
+ "checksum": "{SHA-1}80af2c18f96e94273188808c3d56e561a1cda717",
Review Comment:
```suggestion
"checksum": "{SHA-1}8b82224fd3c6429b6914f32d8339e650770c7526",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1368101595
<b>Trillian test result (tid-5712)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36867 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5712-xenserver-71.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.03 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.04 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7009: Ova checksums
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1414350539
@DaanHoogland
code lgtm
Do we need to update trillian ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1623246511
@weizhouapache @rohityadavcloud I will close this as the differential in shapeblue/Trillian has grown too big. Work there trumps this work at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1521900512
it is relevant and should be integrated with trilian/blueorangutan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361612606
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7009?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7009](https://codecov.io/gh/apache/cloudstack/pull/7009?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4df4cb1) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/08881d69c78026a06dbede893bd2b18976bff5ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08881d6) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #7009 +/- ##
=========================================
Coverage 10.36% 10.36%
- Complexity 6628 6630 +2
=========================================
Files 2453 2453
Lines 242386 242386
Branches 37928 37928
=========================================
+ Hits 25116 25120 +4
+ Misses 214163 214158 -5
- Partials 3107 3108 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1054534322
##########
test/integration/smoke/test_templates.py:
##########
@@ -61,47 +61,27 @@ def setUp(self):
self.domain = get_domain(self.apiclient)
self.zone = get_zone(self.apiclient, self.testClient.getZoneForTests())
+ self.test_template = registerTemplate.registerTemplateCmd()
+ self.test_template.zoneid = self.zone.id
+
if "kvm" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "6952e58f39b470bd166ace11ffd20bf479bed936"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2"
- self.test_template.format = "QCOW2"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "88c60fd500ce7ced985cf845df0db9da"
- self.sha256 = "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
+ hyperindex = "kvm"
if "vmware" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "8b82224fd3c6429b6914f32d8339e650770c7526"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova"
- self.test_template.format = "OVA"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "b4e8bff3882b23175974e692533b4381"
- self.sha256 = "e1dffca3c3ab545a753cb42d838a341624cf25841d1bcf3d1e45556c9fce7cf3"
+ hyperindex = "vmware"
if "xen" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "80af2c18f96e94273188808c3d56e561a1cda717"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2"
- self.test_template.format = "VHD"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "1662bbf224e41bb62b1dee043d785731"
- self.sha256 = "80fba5a7a83842ec4e5f67cc6755d61d4fca46ae170d59b0c6ed47ebf7162722"
+ hyperindex = "xen"
Review Comment:
ah,I got it.
the hypervisor is XenServer, not xen ...
would it be good to change to the following
(1) use "xenserver" instead of "xen" in test_data.py
(2) replace the following by `hyperindex=self.hypervisor.lower()` ?
```
if "kvm" in self.hypervisor.lower():
hyperindex = "kvm"
if "vmware" in self.hypervisor.lower():
hyperindex = "vmware"
if "xen" in self.hypervisor.lower():
hyperindex = "xen"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367844753
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1368124759
<b>Trillian test result (tid-5714)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43209 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5714-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.03 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.02 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.02 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.02 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.63 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429769732
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7009: Ova checksums
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1443873619
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7009)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL)
[![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=coverage&view=list) No Coverage information
[![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7009: Ova checksums
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1414349656
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1415727632
<b>Trillian test result (tid-6094)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50818 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6094-kvm-centos7.zip
Smoke tests completed. 105 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.04 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.03 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.04 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
test_02_upgrade_kubernetes_cluster | `Failure` | 541.56 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Error` | 4035.21 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 78.78 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1481301949
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1540499777
<b>Trillian Build Failed (tid-6524)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367779685
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1446898212
<b>Trillian test result (tid-6233)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39469 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6233-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.05 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.04 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.04 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.03 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.03 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.03 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1617733038
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1413267931
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1368116437
<b>Trillian test result (tid-5713)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 40824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5713-vmware-67u3.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 655.30 | test_kubernetes_clusters.py
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.05 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.04 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.04 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.06 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.05 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.04 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367866987
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367866793
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1434840988
<b>Trillian Build Failed (tid-6196)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1434842570
<b>Trillian Build Failed (tid-6198)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1434870035
<b>Trillian Build Failed (tid-6199)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1443833417
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1540486874
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7009: Ova checksums
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1609136208
ping @DaanHoogland do we need/want this? (I see smoketests are passing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361175223
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361221332
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361221907
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1059272615
##########
tools/marvin/marvin/config/test_data.py:
##########
@@ -992,7 +992,10 @@
"url": "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2",
"requireshvm": "True",
"ispublic": "True",
- "isextractable": "True"
+ "isextractable": "True",
+ "checksum": "{SHA-1}6952e58f39b470bd166ace11ffd20bf479bed936",
+ "md5": "88c60fd500ce7ced985cf845df0db9da",
+ "sha256": "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
},
"xenserver": {
Review Comment:
```suggestion
"xen": {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367844518
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1619702689
@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1617729865
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1619603548
@blueorangutan test rocky8 vmware-72u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1622669113
<b>[SF] Trillian test result (tid-6983)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6983-vmware-70u3.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.06 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.06 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.05 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.05 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.04 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.04 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7009: Ova checksums
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1412172640
Close-reopen to kick Github Actions jobs
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1412173285
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1415259748
> @DaanHoogland code lgtm Do we need to update trillian ?
@weizhouapache , maybe the test_data.py.j2 template. I thought it was already good. I'll have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367865635
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1054490513
##########
test/integration/smoke/test_templates.py:
##########
@@ -61,47 +61,27 @@ def setUp(self):
self.domain = get_domain(self.apiclient)
self.zone = get_zone(self.apiclient, self.testClient.getZoneForTests())
+ self.test_template = registerTemplate.registerTemplateCmd()
+ self.test_template.zoneid = self.zone.id
+
if "kvm" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "6952e58f39b470bd166ace11ffd20bf479bed936"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2"
- self.test_template.format = "QCOW2"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "88c60fd500ce7ced985cf845df0db9da"
- self.sha256 = "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
+ hyperindex = "kvm"
if "vmware" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "8b82224fd3c6429b6914f32d8339e650770c7526"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova"
- self.test_template.format = "OVA"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "b4e8bff3882b23175974e692533b4381"
- self.sha256 = "e1dffca3c3ab545a753cb42d838a341624cf25841d1bcf3d1e45556c9fce7cf3"
+ hyperindex = "vmware"
if "xen" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "80af2c18f96e94273188808c3d56e561a1cda717"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2"
- self.test_template.format = "VHD"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "1662bbf224e41bb62b1dee043d785731"
- self.sha256 = "80fba5a7a83842ec4e5f67cc6755d61d4fca46ae170d59b0c6ed47ebf7162722"
+ hyperindex = "xen"
Review Comment:
the test is for `"xen" in self.hypervisor.lower()`, not for equals. I tried to trust the content as much as the test did before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1481395151
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1445850007
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1445849766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1482745884
<b>Trillian Build Failed (tid-6316)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1482721056
<b>Trillian Build Failed (tid-6315)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429863768
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7009: Ova checksums
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1514281455
@DaanHoogland is this still relevant? Should we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1412274412
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7009: Ova checksums
URL: https://github.com/apache/cloudstack/pull/7009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1623134446
tretesting with adapted Trillian version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1621358785
@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #7009: Ova checksums
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #7009: Ova checksums
URL: https://github.com/apache/cloudstack/pull/7009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1413268407
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1415265559
> > @DaanHoogland code lgtm Do we need to update trillian ?
>
> @weizhouapache , maybe the test_data.py.j2 template. I thought it was already good. I'll have a look.
right, the object at https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2#L1051 needs updating. on my todo list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1361217513
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1362227432
<b>Trillian test result (tid-5607)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41680 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t5607-xenserver-71.zip
Smoke tests completed. 98 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 709.16 | test_kubernetes_clusters.py
test_02_1_create_template_with_checksum_sha1_negative | `Error` | 0.03 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 0.03 | test_templates.py
test_03_1_create_template_with_checksum_sha256_negative | `Error` | 0.02 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 0.02 | test_templates.py
test_04_1_create_template_with_checksum_md5_negative | `Error` | 0.02 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 0.02 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 0.03 | test_templates.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 306.25 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 306.27 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.22 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1058955450
##########
tools/marvin/marvin/config/test_data.py:
##########
@@ -1003,7 +1006,10 @@
"url": "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2",
"requireshvm": "True",
"ispublic": "True",
- "isextractable": "True"
+ "isextractable": "True",
+ "checksum": "{SHA-1}80af2c18f96e94273188808c3d56e561a1cda717",
+ "md5": "1662bbf224e41bb62b1dee043d785731",
+ "sha256": "80fba5a7a83842ec4e5f67cc6755d61d4fca46ae170d59b0c6ed47ebf7162722"
Review Comment:
```suggestion
"sha256": "e1dffca3c3ab545a753cb42d838a341624cf25841d1bcf3d1e45556c9fce7cf3"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367797415
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1434849373
<b>Trillian Build Failed (tid-6197)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1443751173
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7009: Ova checksums
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1481468452
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7009)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL)
[![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=coverage&view=list) No Coverage information
[![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1540493176
<b>Trillian Build Failed (tid-6523)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1621357639
@blueorangutan test rocky8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1443750521
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429768136
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1054398716
##########
test/integration/smoke/test_templates.py:
##########
@@ -61,47 +61,27 @@ def setUp(self):
self.domain = get_domain(self.apiclient)
self.zone = get_zone(self.apiclient, self.testClient.getZoneForTests())
+ self.test_template = registerTemplate.registerTemplateCmd()
+ self.test_template.zoneid = self.zone.id
+
if "kvm" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "6952e58f39b470bd166ace11ffd20bf479bed936"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2"
- self.test_template.format = "QCOW2"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "88c60fd500ce7ced985cf845df0db9da"
- self.sha256 = "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
+ hyperindex = "kvm"
if "vmware" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "8b82224fd3c6429b6914f32d8339e650770c7526"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova"
- self.test_template.format = "OVA"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "b4e8bff3882b23175974e692533b4381"
- self.sha256 = "e1dffca3c3ab545a753cb42d838a341624cf25841d1bcf3d1e45556c9fce7cf3"
+ hyperindex = "vmware"
if "xen" in self.hypervisor.lower():
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template = registerTemplate.registerTemplateCmd()
- self.test_template.checksum = "{SHA-1}" + "80af2c18f96e94273188808c3d56e561a1cda717"
- self.test_template.hypervisor = self.hypervisor
- self.test_template.zoneid = self.zone.id
- self.test_template.name = 'test sha-2333'
- self.test_template.displaytext = 'test sha-1'
- self.test_template.url = "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-xen.vhd.bz2"
- self.test_template.format = "VHD"
- self.test_template.ostypeid = self.getOsType("Other Linux (64-bit)")
- self.md5 = "1662bbf224e41bb62b1dee043d785731"
- self.sha256 = "80fba5a7a83842ec4e5f67cc6755d61d4fca46ae170d59b0c6ed47ebf7162722"
+ hyperindex = "xen"
Review Comment:
`hyperindex=self.hypervisor.lower()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367779822
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1367779494
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1414349876
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7009: Ova checksums
Posted by sonarcloud.
sonarcloud[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1412280232
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7009)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7009&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7009&resolved=false&types=CODE_SMELL)
[![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=coverage&view=list) No Coverage information
[![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7009&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1481303339
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-code-scanning[bot] commented on pull request #7009: Ova checksums
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1482423348
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository [Security tab](/apache/cloudstack/security/code-scanning?query=pr%3A7009+tool%3ASonarCloud+is%3Aopen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7009: Ova checksums
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1537881051
Thanks @DaanHoogland let's fix this and pull it out of draft then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7009: Ova checksums
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#discussion_r1059272615
##########
tools/marvin/marvin/config/test_data.py:
##########
@@ -992,7 +992,10 @@
"url": "http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2",
"requireshvm": "True",
"ispublic": "True",
- "isextractable": "True"
+ "isextractable": "True",
+ "checksum": "{SHA-1}6952e58f39b470bd166ace11ffd20bf479bed936",
+ "md5": "88c60fd500ce7ced985cf845df0db9da",
+ "sha256": "bc4cc040bbab843000fab78db6cb4a33f3a06ae1ced2cf563d36b38c7fee3049"
},
"xenserver": {
Review Comment:
```suggestion
"xen": {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1623215997
<b>[SF] Trillian Build Failed (tid-7001)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org