[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219361#comment-16219361 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
-------------------------------------------

GitHub user fr0stbyte opened a pull request:

    https://github.com/apache/zookeeper/pull/407

    [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined

    This addresses the issue in https://issues.apache.org/jira/browse/ZOOKEEPER-2338 preventing the sockets to leak into the forked children 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fr0stbyte/zookeeper radu/cloexec_on_c_client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #407
    
----
commit 431742cd8f1726c17e3afdedf553b79663294177
Author: Radu Brumariu <ra...@groupon.com>
Date:   2017-10-25T18:24:17Z

    [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined

----


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec
> ----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2338
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: James DeFelice
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)